Open NoRi2909 opened 3 days ago
Note that I also filed this bug because one German translator already changed part of this in German creating even more inconsistencies that I had to revert to get a clear picture of the whole issue.
So this bug is meant to bring full consistency in the English original that we can then follow in translations.
There's a design guideline to use "create" whenever something creates something new in the installation (create automation and create script) and we use "add" whenever something is added onto something that is already created (adding a card to an existing dashboard, add permissions to an user) => https://design.home-assistant.io/#Text/remove-delete-add-create
@silamon I think this guideline backs all I suggested in my bug report above.
Keep "create" for "Create new script" and "Create new automation" as it is today, because they are made from scratch, but use "add" for turning an existing blueprint into an automation or script.
But if you prefer to use "create" for all of those then the current "Add script" and "Add scene" buttons are the ones that are to be fixed (see in the second and third screenshot above).
Regardless there is an inconsistency now that needs to be fixed.
Describe the issue you are experiencing
With Blueprints creating a (new) automation or script is just one option of adding one of them.
So the action button and dialog title for both should be
where
are just suboptions in those dialogs besides picking some pre-made blueprints instead.
Currently there is quite some inconsistency here. For Automations we have the wrong "Create" in both places:
and for Scripts the button is correct with "Add", but the dialog title is using the wrong "Create":
Describe the behavior you expected
Now this can be fixed easily by changing the following five strings to "Add …"
The wrong button:
https://github.com/home-assistant/frontend/blob/b83be385141a6d4513afc4848902745bcc31054f/src/translations/en.json#L2828
The dialog headers:
https://github.com/home-assistant/frontend/blob/b83be385141a6d4513afc4848902745bcc31054f/src/translations/en.json#L2873
https://github.com/home-assistant/frontend/blob/b83be385141a6d4513afc4848902745bcc31054f/src/translations/en.json#L3763
And from the menu under Blueprints (where this item is also illustrated with a "+" icon):
https://github.com/home-assistant/frontend/blob/b83be385141a6d4513afc4848902745bcc31054f/src/translations/en.json#L3693-L3694
BTW, this also makes them consistent with the third button in this area that is already "Add …":
What version of Home Assistant Core has the issue?
core-2024.11.1