home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
4.02k stars 2.75k forks source link

Add new integrations dialog appears beneath keyboard when filtered (on mobile/iOS) #4692

Closed SeanPM5 closed 4 years ago

SeanPM5 commented 4 years ago

Checklist

The problem

Because the integrations dialog is a bottom sheet, when you search for a specific integration (such as Spotify in this example) the entire dialog shrinks to the bottom. This appears underneath the keyboard on mobile devices - at least with iOS. So you cannot see what you're typing, and you cannot see the results. Annotated screenshots below, the middle one is the main problem.

image

Expected behavior

Make the dialog show in the center of the screen or use the whole screen (like more info) rather than being attached to the bottom. Keyboards take up like half the screen on mobile devices.

Steps to reproduce

  1. Use an iPhone
  2. Go to Configuration > Integrations
  3. Press FAB / + button and type Spotify

Environment

Problem-relevant configuration

Javascript errors shown in your browser console/inspector

Additional information

stale[bot] commented 4 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

SeanPM5 commented 4 years ago

Still an issue in 0.109.

Here I search for "wemo" and there is a result, but it's completely invisible cause it renders underneath the keyboard. If you look at the 123 button on the keyboard you can see the faint green wemo brand icon behind there.

image

This is how it should look imo, always visible in the center of the screen above the keyboard.

image

SeanPM5 commented 4 years ago

No longer an issue in 0.112, dialog now always keeps the same size 🎉