home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
4.07k stars 2.79k forks source link

0.110 broke gauges visualization #5943

Closed sblantipodi closed 4 years ago

sblantipodi commented 4 years ago

Checklist

The problem

Latest 0.110 update broke type: gauge an image speaks better than what I can do.

1

2

3

as you can see gauges are misaligned now, with bigger and smaller gauge in the same horizontal layout.

before it worked better.

smartostat_dashboard

Environment

MuppetOwl commented 4 years ago

Can also confirm similar issue. gauges does not look good on desktop (text to large) and on tablet/phone they take up way to much space now.

Annotation 2020-05-20 152729

bramkragten commented 4 years ago

Please follow the issue template.

What is your config?

Also add a clear before/after image. I see a lot of images but I'm not sure what I'm looking at.

sblantipodi commented 4 years ago

Please follow the issue template.

What is your config?

Also add a clear before/after image. I see a lot of images but I'm not sure what I'm looking at.

Sincerely I don't know what are the improvements bringed on gauge but I see only regression.

cards:
  - cards:
      - entity:
          - sensor.room_humidity
        type: gauge
        unit: '%'
      - entity:
          - sensor.room_pressure
        max: 1050
        min: 950
        type: gauge
        unit: hPa
      - entity:
          - sensor.room_gasresistance
        max: 1400
        min: 0
        type: gauge
        unit: KOhms
    type: horizontal-stack
  - cards:
      - entity:
          - sensor.room_iaq
        max: 500
        min: 0
        type: gauge
        unit: IAQ
      - entity:
          - sensor.cyberpower_watt_load
        max: 1350
        min: 0
        type: gauge
        unit: W
      - entity:
          - sensor.cyberpower_pr1500elcd_battery_charge
        max: 100
        min: 0
        type: gauge
        unit: '%'
    type: horizontal-stack
type: vertical-stack

Screenshot_20200520-191351

gauses was correctly aligned before, now it is misaligned as you can see from this image, the gauge bar was fatter, now is so slim why?

it's not difficult to reproduce, simply use my vertical stack

bramkragten commented 4 years ago

You know, the problem is, I have no idea what it looked liked or behaved before. That's why I ask for a clear before/after comparison, so I can see the regression you are talking about.

Not all changes are done for visual reasons, sometimes things are done for technical reasons, and then there is taste, what one likes, the other may dislike.

sblantipodi commented 4 years ago

You know, the problem is, I have no idea what it looked liked or behaved before. That's why I ask for a clear before/after comparison, so I can see the regression you are talking about.

Not all changes are done for visual reasons, sometimes things are done for technical reasons, and then there is taste, what one likes, the other may dislike.

I don't know if the last picture I sent is clear, I think that the picture speaks for itself. I have 6 gauges, 4 seems to have the same size, 1 is smaller than the other and 1 is mialigned.

before the upgrade 6 gauges was of the same size and perfectly aligned.

is this a question of taste?

I can't send you a picture of the "previous state" since I upgraded and I don't want to rollback just for this. I hope that the picture I gived you is enough.

thanks.