search

home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
4.02k stars 2.74k forks source link

Setting location is not accessible #5991

Open steverep opened 4 years ago

steverep commented 4 years ago

Checklist

The problem

The current method for setting the location via the UI requires visual interaction with a pointer to set latitude and longitude. This is not accessible for screen reader users or other assistive technology requiring keyboard control.

Expected behavior

There needs to be a keyboard only method for setting location either via coordinates or physical address.

Steps to reproduce

N/A

Environment

stale[bot] commented 4 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

steverep commented 4 years ago

Yes, this is certainly still an issue.

github-actions[bot] commented 3 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

steverep commented 3 years ago

Yes, still an issue. And could probably be easily solved simply by adding input fields to show/edit the longitude and latitude coordinates.

github-actions[bot] commented 3 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

steverep commented 3 years ago

Yep, still an issue.

github-actions[bot] commented 3 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

steverep commented 3 years ago

Please re-open. This is still an issue.

github-actions[bot] commented 3 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

steverep commented 3 years ago

Yes, still an issue.

spacegaier commented 3 years ago

@matthiasdebaat Any ideas how to best handle this?

matthiasdebaat commented 3 years ago

We could use the same pattern as we have in the onboarding? Where there's a button to detect your location.

Sorry for the dutch language screenshot

spacegaier commented 3 years ago

I just thought about it some more: What if the home location cannot reliably be detected automatically? Not sure how often that happens though.

For manually created zones, we have this UI where you have input fields: image

matthiasdebaat commented 3 years ago

It's good to offer this option, this helps a user to specify his exact location. I think it's a bit hard to use this with screen reader or other assistive technology. @steverep do you have experience with this?

github-actions[bot] commented 2 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

steverep commented 2 years ago

Can we stop the bot from closing this?

frenck commented 2 years ago

By responding before it closes :)

steverep commented 2 years ago

It's Home Assistant not Home Ruler. Playing by the bot's rules makes for a boring movie plot.

steverep commented 2 years ago

Please re-open. This is certainly still an issue.

github-actions[bot] commented 2 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

steverep commented 2 years ago

Yup, still a problem.

github-actions[bot] commented 2 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Nardol commented 2 years ago

It is still an issue

joshms123 commented 2 years ago

This looks like it has been an issue for a while. Is anybody looking into it?

steverep commented 2 years ago

@joshms123 there are quite a few accessibility issues, some hanging around for a while like this one. I've been trying to improve accessibility one issue at a time through various contributions, but I'm not part of the HA team so my time is limited. At least this one has a workaround to use Yaml.

Specific to this issue,inputting coordinates is a start and is possible in the latest version, but I wouldn't regard it as equal access until I can search for an address via keyboard.

steverep commented 2 years ago

@bramkragten @zsarnett can fixing this finally be made a priority? The ability to add/edit zone locations by inputting latitude and longitude now exists for other zones, but cannot be done for the home zone. That seems pretty silly.

Since the focus of this year is supposed to be streamlining experiences, it would be nice to simply be able to quickly enter physical addresses rather than fumbling through a map. This is one of the first things new HA users need to do, so it should be as easy and accessible as possible.

Am I missing a technical hurdle?

johanhallberg commented 1 year ago

I agree, this "should" be fixed as new HA users (and old ones like me) really like to control this - preferably without yaml-code. The radius parameter is really something very useful, and especialy for your primary location as home... 😁

I hope this is not too hard as all other zones got this?

Shadowex3 commented 1 year ago

@johanhallberg agreed. It's astounding to me that this isn't an option, and even more incomprehensible that it was in the past and then somehow the decision was made to deliberately cripple and remove functionality for apparently no reason at all. It's the sort of thing I'd expect from Apple perhaps before they sell you a new device with the crippled feature re-added at extra cost.

The default size of the "home" zone is positively enormous too. Unless you live in the midwest on some acreage that's going to be several houses or an entire city block.

rekinet commented 1 year ago

It doesn't take much to solve this problem. All that's needed is the ability to enter the latitude and longitude. This can be done for other locations, but there has never been such an option for home location. The problem is very old. Maybe it's time to finally solve it?

KTibow commented 1 year ago

Wasn't there a new location picker that made this accessible?

steverep commented 1 year ago

Wasn't there a new location picker that made this accessible?

Only for on boarding, and honestly, I haven't even tested that yet

github-actions[bot] commented 10 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

lindhe commented 7 months ago

Calling this an accessibility issue is really belittling the issue. I have no disabilities and I struggled for 10+ minutes trying to figure out how to change the location on the map. 😂 Drag-and-dropping great distances is pretty usual UX, I think.

steverep commented 7 months ago

Calling this an accessibility issue is really belittling the issue.

Are you sure you want to use the word "belittling" here? In doing so, you are implying that accessibility issues should be treated with less importance than others, which certainly some users would find pretty offensive.

I have no disabilities and I struggled for 10+ minutes trying to figure out how to change the location on the map. 😂 Drag-and-dropping great distances is pretty usual UX, I think.

Improving drag and drop has nothing to do with this issue.

D3SL commented 7 months ago

@steverep You know those memes about someone saying they like coca cola and then getting dogpiled by a bunch of people accusing them of hating pepsi? Anyone acting in good faith can very clearly see @lindhe was using humor to express just how significant of an impediment to any meaningful use of the system this is.

At no point would any reasonable person acting in good faith think he was demeaning accessibility issues. Especially considering he's from Sweden, and I'm pretty sure neither of us speak Swedish as good as he speaks English. Although I could get by in Finnish in a pinch.

steverep commented 7 months ago

@D3SL please don't accuse me of being unreasonable or acting in bad faith, or lecture me on what should or should not be considered offensive. I'm perfectly capable of handling that on my own. My comment certainly gave every benefit of the doubt deserved, and simply offered a perspective and chance to reconsider the choice of wording for whatever reason.

I didn't find "belittling" humorous, and I know I wouldn't be alone in that. If you did, then you either need a dictionary or perhaps an introspective moment to step back and consider why.

Lastly, these comments have nothing to do with the issue, so I will hide them and request moving on before it diverges further.

karwosts commented 7 months ago

Made some updates in #19994 which may address some of the points here. I don't think if it has everything you asked for (no addresses), but it should be more accessible.

github-actions[bot] commented 4 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

lindhe commented 4 months ago

Ping

github-actions[bot] commented 1 month ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

lindhe commented 1 month ago

Ping