home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
3.94k stars 2.66k forks source link

Material Design Icons out of date #6162

Closed SeanPM5 closed 4 years ago

SeanPM5 commented 4 years ago

Checklist

The problem

Material Design Icons version bump in Home Assistant was last done ~5 months ago by @goyney in PR https://github.com/home-assistant/frontend/pull/4764 (to v4.9.95).

Since then v5.0.45 released with a large number of breaking changes. Understandably, it hasn't been updated yet due to this reason. But at this point it's falling quite far behind. There's a difference of at least 570+ icons by my quick count (120 renames, 450 additions).

Most people use the search box on materialdesignicons.com to find icons and expect whatever they see there to work in Home Assistant. There's also things like this Visual Code extension that suggests icons after typing mdi: and is suggesting icons that don't work in HA (yet). A member of the community also created a cool alternative site and this too also shows the renamed and newly added icons.

Breaking Changes: The full list of breaking changes is here: https://github.com/Templarian/MaterialDesign/issues/4901 and on the MDI Changelog and Upgrade Guide.

Here's a small sample showing some of the most commonly used icons in Home Assistant. I think that almost every Home Assistant user will have at least one of these icons used in their setup:

Icon Old Name New Name
image mdi:hotel mdi:bed
settings mdi:settings mdi:cog
timer mdi:timer mdi:timer-outline

I had seen a suggestion to remap the icon names in the past, but even if such a thing is done it would only lessen the impact (albeit significantly) of this breaking change, not eliminate it entirely. It wouldn't be possible to remap the ~75 or so brand icons that got removed.

This was not intended to rush anything along, just wanted there to be a detailed issue for this so that users can be easily linked to an explanation for the delay. Though if there's ever a good time to put out a breaking change like this, it's probably during quarantine when everyone's at home to fix it 😄

Expected behavior

Icon selection and names in Home Assistant should ideally be consistent with what users see on the materialdesignicons.com website and other sources.

Steps to reproduce

Environment

State of relevant entities

Problem-relevant configuration

Javascript errors shown in your browser console/inspector

Additional information

mririgoyen commented 4 years ago

This is a duplicate of #5094.

SeanPM5 commented 4 years ago

Ah thanks, missed that issue.