home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
3.99k stars 2.72k forks source link

a hold action shows the iPhone Share, Add to photos, Copy pop up. #9549

Open Mariusthvdb opened 3 years ago

Mariusthvdb commented 3 years ago

A Safari browser on the same iPhone does execute the action.

I am not able to reproduce this -- but no matter what, the fix needs to be in the frontend (using the CSS mentioned above). Feel free to re-open over there, if it's the base picture entity and nothing custom.

Originally posted by @zacwest in https://github.com/home-assistant/iOS/issues/1698#issuecomment-877732770

recap:

  - type: entities
    entities: []
    header:
      type: picture
      image: /local/weather/weatherbit.png
      tap_action:
        action: url
        url_path: !secret weatherio_api_url
      hold_action:
        action: call-service
        service: homeassistant.reload_config_entry
        service_data:
          entry_id: 79ae77f927714985b1046191c05f2b5c

performs Ok when in a regular safari browser window on the iPhone. In the App however, a hold action shows the Share, Add to photos, Copy pop up.

according to Zac, this should be done:

needs to disable this via webkit-touch-callout, see lovelace version.

smart-ctrl commented 3 years ago

I got the same problem with hold action when using a picture-entity card and the Home Assistant iOS app.

Mariusthvdb commented 3 years ago

would it be possible to have somebody have a look at this? it really is an annoying bug and takes away from the frontend functionality. P{lease let me know if I can help to fix

github-actions[bot] commented 2 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Mariusthvdb commented 2 years ago

Don't close please, nothing changed ...

github-actions[bot] commented 2 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Mariusthvdb commented 2 years ago

Still happening in 2022.5 dev

github-actions[bot] commented 2 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Mariusthvdb commented 2 years ago

Still happening in 2022.8 dev

github-actions[bot] commented 2 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Mariusthvdb commented 2 years ago

Still happening 2022.10 .....

Mariusthvdb commented 1 year ago

and still on 2022.11

just now, I realized its not only happening on posted service above, but also eg on this navigate within the Ha frontend:

    type: picture-entity
    entity: input_boolean.ventilate
    name: Ventilate
    image: /local/images/ventilate.png
    state_filter:
      'off': grayscale(72%)
    tap_action:
      action: toggle
    hold_action:
      action: navigate
      navigation_path: /ui-data/climate

Holding brings up the identical IOS popup, instead of executing the service.. @spacegaier sorry for the tag, but why doesn't this get some attention? or as I asked on Discord: such fundamental functionality on a leading product, why is this not prioritized....

it's been over a year without any progress

Mosher23 commented 1 year ago

Why os this „closed“?! I have same issue since I can remember using HA. Example to reproduce: Muschroom Template card picture instead of icon. Long press set to toggle. long pressing on iphone opens system Preview/share menu on iphone.

Mariusthvdb commented 1 year ago

please only comment with core elements, otherwise the devs tend to state its the custom element causing the issue.

this btw hasn't been closed, it is wide open for more than a year now, without as much as a blink of a Frontend dev's eye, not a single response. as if this just doesn't exist.

iOS app Zac even pointed to the solution https://github.com/home-assistant/iOS/issues/1698#issuecomment-877684390 . I don't understand that, but the Frontend devs would I suppose....

JGKarlin commented 1 year ago

The hold tap action doesn't work on iOS devices if that entity is displayed in lovelace with an image. It's hard to believe that this issue is not being addressed.

Mariusthvdb commented 1 year ago

yes, really peculiar.

moved away from the opening config, but this is a fine example too:

  - type: picture-entity
    show_state: false
    show_name: false
    entity: camera.weer_roosendaal
    hold_action:
      action: url
      url_path: https://www.yr.no/en/forecast/graph/2-2747930/Netherlands/North%20Brabant/Roosendaal/Roosendaal

no url opening, just the mentioned share dialog. iOS app only.

Btw: making that a tap_action with the exact config works fine. So its definitely the hold_action itself conflicting in the app

this is on HA 2023.4.0b5 and the latest iOS app beta 2023.459

Ive had a single succes to add a card_mod to the picture:

  - type: picture-entity
    card_mod:
      style: |
        ha-card {
          cursor: pointer;
          overflow: hidden;
          -webkit-touch-callout: none !important;
      }

but that is fr from stable, as all consecutive hold_actions again show a picture, within a picture.

most reliable seems to be to have tap_action be a default, so more-info, and for navigation, use double_tap_action.

    double_tap_action:
      action: url
      url_path: https://www.yr.no/en/forecast/graph/2-2747930/Netherlands/North%20Brabant/Roosendaal/Roosendaal

which is too bad, because I use hold_action throughout the config for navigation, so this is counter intuitive. and a hack ofc, because hold_action should simply be fixed/work.

github-actions[bot] commented 10 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Mariusthvdb commented 10 months ago

Keep

github-actions[bot] commented 7 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Mariusthvdb commented 7 months ago

keep

github-actions[bot] commented 4 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Mariusthvdb commented 4 months ago

Keep

github-actions[bot] commented 1 month ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Mariusthvdb commented 1 month ago

Keep

Mariusthvdb commented 4 weeks ago

Keep