home-assistant / home-assistant.io

:blue_book: Home Assistant User documentation
https://www.home-assistant.io
Other
4.73k stars 7.16k forks source link

Consistency with units #32983

Closed theukedge closed 3 weeks ago

theukedge commented 3 months ago

Feedback

I'm not sure what the issue is here, but it's one of two things:

  1. The integration uses metres in the Tolerance calculation, regardless of the user's native distance units, or
  2. The integration uses the user's native distance units for the Tolerance calculation and the documentation is wrong.

The documentation also describes what the tolerance distance is, but I think it could be made clearer. I offer the following:

When adding the Proximity integration, you are prompted to define the Tolerance Distance. Because GPS is imperfect and the location is adjusting slightly all the time, the tolerance distance helps to filter out insignificant movements. Once the device/person has moved in excess of the tolerance distance, a change in the Direction of Travel is calculated.

URL

https://www.home-assistant.io/integrations/proximity/

Version

2024.5.5

Additional information

Note that the Markdown is not respected in the Note callout

home-assistant[bot] commented 3 months ago

Hey there @mib1185, mind taking a look at this feedback as it has been labeled with an integration (proximity) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `proximity` can trigger bot actions by commenting: - `@home-assistant close` Closes the feedback. - `@home-assistant rename Awesome new title` Renames the feedback. - `@home-assistant reopen` Reopen the feedback. - `@home-assistant unassign proximity` Removes the current integration label and assignees on the feedback, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information) to the feedback. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information) on the feedback.
github-actions[bot] commented 1 month ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved. If this issue is still relevant, please let us know by leaving a comment 👍 This issue has now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

mib1185 commented 3 weeks ago

Hi @theukedge

in the backend all calculations are done in meters and later converted based on the selected unit system in HA (see setup basic information). Therefore the tolerance needs to be provided in meters and is used to filter out small GPS changes due to inaccuracies of GPS. I agree that the current hint is somehow unclear formulated, will fix this soon