home-assistant / home-assistant.io

:blue_book: Home Assistant User documentation
https://www.home-assistant.io
Other
4.72k stars 7.15k forks source link

SleepNumber integration docs #33047

Closed ehcloninger closed 1 week ago

ehcloninger commented 2 months ago

Feedback

Wasn't sure of the protocol for submitting docs changes. I didn't want to clone and go thru the PR process for a 1 line docs change.

I had issues getting the configuration to work and it had me stumped for a while. Then, I remember I have specific rules in my pihole to keep the bed from phoning home so much. I suggest adding a line such as

If you are using a DNS-based ad-blocker, you may need to disable it temporarily while configuring this item in Home Assistant.

URL

https://www.home-assistant.io/integrations/sleepiq/

Version

2024.5.5

Additional information

No response

home-assistant[bot] commented 2 months ago

Hey there @mfugate1, @kbickar, mind taking a look at this feedback as it has been labeled with an integration (sleepiq) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `sleepiq` can trigger bot actions by commenting: - `@home-assistant close` Closes the feedback. - `@home-assistant rename Awesome new title` Renames the feedback. - `@home-assistant reopen` Reopen the feedback. - `@home-assistant unassign sleepiq` Removes the current integration label and assignees on the feedback, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information) to the feedback. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information) on the feedback.
kbickar commented 2 months ago

It's gonna need a pr if you do it or we do. Which address was being blocked?

ehcloninger commented 2 months ago

@kbickar I had a regex block for (.|^)sleepnumber.com$ and an allowlist for svcsleepiq.sleepnumber.com. The problem with their bed is it sends something like 100,000 requests per day to firehose.us-east-1.amazonaws.com and I was trying to contain that a bit.

As a rule, I don't like giving any company that much access to data without knowing what it is. Especially that sleep data is medical data.

I don't mind doing a PR. I'm a developer in my other life. I'm just starting out with HA and trying to understand the culture.

kbickar commented 2 months ago

Interesting, it's probably the bed itself making those requests as the integration only connects to the one endpoint once a minute

ehcloninger commented 2 months ago

@kbickar My first PR to home-assistant, so I hope I followed the process correctly.

https://github.com/home-assistant/home-assistant.io/pull/33061

github-actions[bot] commented 2 weeks ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved. If this issue is still relevant, please let us know by leaving a comment 👍 This issue has now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.