home-assistant / home-assistant.io

:blue_book: Home Assistant User documentation
https://www.home-assistant.io
Other
4.99k stars 7.29k forks source link

Button action config example not correct on Android TV Remote integration documentation #34201

Closed adorobis closed 3 months ago

adorobis commented 3 months ago

Feedback

The card example provided on Android TV Remote integration documentation is not correct, it now has some duplicate action: keys. Not sure if the frontend is now fully aligned to the rename of "service" into "action", I believe in case of button actions we have a bit of confusion now. I guess too much search&replace has happened here :) Example of wrong code in the document:

      - type: button
        icon: mdi:arrow-up-bold
        tap_action:
          action: call-service
          action: remote.send_command
          data:
            command: DPAD_UP
          target:
            entity_id: remote.living_room_tv

a correctly working example:

      - type: button
        icon: mdi:arrow-up-bold
        tap_action:
          action: call-service
          service: remote.send_command
          data:
            command: DPAD_UP
          target:
            entity_id: remote.googletv

URL

https://www.home-assistant.io/integrations/androidtv_remote/

Version

2024.8.0

Additional information

No response

home-assistant[bot] commented 3 months ago

Hey there @tronikos, @drafteed, mind taking a look at this feedback as it has been labeled with an integration (androidtv_remote) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `androidtv_remote` can trigger bot actions by commenting: - `@home-assistant close` Closes the feedback. - `@home-assistant rename Awesome new title` Renames the feedback. - `@home-assistant reopen` Reopen the feedback. - `@home-assistant unassign androidtv_remote` Removes the current integration label and assignees on the feedback, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information) to the feedback. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information) on the feedback.
tronikos commented 3 months ago

Fixed in https://github.com/home-assistant/home-assistant.io/pull/34228