home-assistant / home-assistant.io

:blue_book: Home Assistant User documentation
https://www.home-assistant.io
Other
4.95k stars 7.26k forks source link

Amcrest example broken with PR #34023 #34337

Closed urdaalex closed 1 month ago

urdaalex commented 2 months ago

Feedback

34023 bulk renamed some docs and now the 'action' key shows up twice for the Amcrest integration. The example below will not run when tested on my 2024.5.5

Example: https://www.home-assistant.io/integrations/amcrest/#example-card-with-controls

elements:
  - type: icon
    icon: "mdi:arrow-up"
    style:
      background: "rgba(255, 255, 255, 0.25)"
      right: 25px
      bottom: 50px
    tap_action:
      action: call-service   ## <----- used to be a 'service' key
      action: amcrest.ptz_control  ## <----- duplicate 'action' key
      service_data:
        entity_id: camera.lakehouse
        movement: up

URL

https://www.home-assistant.io/integrations/amcrest/

Version

2024.8.2

Additional information

No response

home-assistant[bot] commented 2 months ago

Hey there @flacjacket, mind taking a look at this feedback as it has been labeled with an integration (amcrest) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `amcrest` can trigger bot actions by commenting: - `@home-assistant close` Closes the feedback. - `@home-assistant rename Awesome new title` Renames the feedback. - `@home-assistant reopen` Reopen the feedback. - `@home-assistant unassign amcrest` Removes the current integration label and assignees on the feedback, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information) to the feedback. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information) on the feedback.
DeathCamel58 commented 1 month ago

This has been fixed with #34348

Can we get this closed?