search

home-assistant / homebridge-homeassistant

DEPRECATED in favor of native HomeKit support. -  Homebridge plugin for Home Assistant
https://www.home-assistant.io/components/homekit/
Other
683 stars 144 forks source link

Remove the need to use NODE_TLS_REJECT_UNAUTHORIZED=0 #187

Closed oznu closed 7 years ago

oznu commented 7 years ago

This pull request will allow a self signed certificate on the Home Assistant server without needing to use NODE_TLS_REJECT_UNAUTHORIZED=0.

Using NODE_TLS_REJECT_UNAUTHORIZED=0 also stops TLS verification checks for every other plugin that is enabled in the user's Homebridge config, even those making connections out to the internet, which makes using this approach very insecure.

This change allows TLS verification checks to be disabled via the config.json file specifically for this plugin.

"verify_ssl": false

TLS checks remain enabled by default for users who do not set the verify_ssl option and users who currently use NODE_TLS_REJECT_UNAUTHORIZED=0 to disable TLS verification can continue to do so.

homeassistant commented 7 years ago

Hi @oznu,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

robbiet480 commented 7 years ago

Thanks! 🐬 🍪 💯