Update alarm_control_panel.js

home-assistant / homebridge-homeassistant

DEPRECATED in favor of native HomeKit support. -  Homebridge plugin for Home Assistant

https://www.home-assistant.io/components/homekit/

Other

683 stars 144 forks source link

Update alarm_control_panel.js #262

Closed JAYMAN-ATX closed 6 years ago

JAYMAN-ATX commented 6 years ago

reversed temporary workaround from https://github.com/home-assistant/homebridge-homeassistant/commit/01059c1e93ddb5ffbea3acee6dab2ff2753975e8
fixed string to reflect correct state

homeassistant commented 6 years ago

Hi @JAYMAN-ATX,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

schmittx commented 6 years ago

Looks OK to me, can you update the README also?

JAYMAN-ATX commented 6 years ago

Sorry, I couldn't figure out how to add another file to this pull request, so I created another one.

schmittx commented 6 years ago

Looks good! Thanks!

GraysonAdams commented 6 years ago

I would like to point out that this issue does not appear to be resolved.

Pressing "Arm night" on the latest version for a manual alarm control panel component actually "Arms home" and makes HomeKit malfunction, as it is expecting the "Armed night" response and does not get it, so it just says... Pending......

JAYMAN-ATX commented 6 years ago

That patch is not yet included in the latest distribution package. You have to modify the source file (accessories/alarm_control_panel.js) manually on your local server and restart homebridge to resolve the issue.