search

home-assistant / homebridge-homeassistant

DEPRECATED in favor of native HomeKit support. -  Homebridge plugin for Home Assistant
https://www.home-assistant.io/components/homekit/
Other
683 stars 144 forks source link

Add support for humidity sensor where the entity_id is moisture #274

Closed honcheng closed 6 years ago

honcheng commented 6 years ago

Xiaomi Flora has support for soil moisture, which is equivalent to humidity. But the homebridge_sensor_type is undefined, so it has to be matched by entity_id.

schmittx commented 6 years ago

You can use customize to set homebridge_sensor_type to humidity and it will be populated in Homebridge.

This PR just makes another special case, I don't think it's really necessary.

netmanchris commented 6 years ago

New to Homebridge so apologize for the noob question. In your opinion, should the homebridge_sensor_type to humidity change be submitted as a PR to the Xioami flower plugin?

I'd also like this to work and am more than happy to submit the PR. Just trying to wrap my mind around the framework.

ciotlosm commented 6 years ago

@netmanchris you don't need a PR, you can use customisation to set that. I think this PR is not helpful as it uses string matching on entityId for a very special case.