search

home-assistant / homebridge-homeassistant

DEPRECATED in favor of native HomeKit support. -  Homebridge plugin for Home Assistant
https://www.home-assistant.io/components/homekit/
Other
683 stars 144 forks source link

Climate operation modes fix #324

Closed sergeymaysak closed 6 years ago

sergeymaysak commented 6 years ago

Guys, I've noticed that zwave climate I use exposed to homebridge is not able to change operation mode as well as not reflects changes of operation mode from home assistant UI.

So climate.js logic assumes that names of states are lowercased as 'off', 'heat', 'cool', 'auto', while home assistant (v. 72, 74 for example) uses 'Off' and 'Heat' etc.

So this pull requests adds corresponding changes to make sure climate shown at homekit is able to change actual operation mode and reflects device changes correctly as well.

I'm not sure if 'Heat'/'Off' pattern is used always for any other types of thermostats, so I've tried to add changes not broking previous (lowercase always) way of mode naming.

Cheers )

robbiet480 commented 6 years ago

Thanks for your submission. Sadly, homebridge-homeassistant is now deprecated so this code can't be accepted. Please find more information in the README.md