Missing Complications: Graphic Circular Stack Image and Stack Text

home-assistant / iOS

:iphone: Home Assistant for Apple platforms

https://companion.home-assistant.io

Other

1.58k stars 308 forks source link

Missing Complications: Graphic Circular Stack Image and Stack Text #1643

Open jschwalbe opened 3 years ago

jschwalbe commented 3 years ago

iOS device model, version and app version

Model Name: iPhone 12 Software Version: App version: 2021.5

Home Assistant Core Version

Home Assistant 2021.5.5

Describe the bug I was trying to create an Apple Watch Complication for use with the Infograph Modular face. According to https://developer.apple.com/design/human-interface-guidelines/watchos/overview/complications/ there should be an option to create Graphic Circular Stack Image (I'm trying to recreate the sunset/rise behavior). This does not exist.

To Reproduce & Expected Behavior Create a new complication. Select Graphic Circular. Template should have Stack Image, but it does not.

Screenshots

Additional context

zacwest commented 3 years ago

Checking out the templates, the following are new in watchOS 6/7:

CLKComplicationTemplateGraphicCircularStackText
CLKComplicationTemplateGraphicCircularStackImage
CLKComplicationTemplateGraphicRectangularFullImage

The following are noted in #1175:

CLKComplicationTemplateGraphicExtraLargeCircularImage
CLKComplicationTemplateGraphicExtraLargeCircularOpenGaugeRangeText
CLKComplicationTemplateGraphicExtraLargeCircularOpenGaugeSimpleText
CLKComplicationTemplateGraphicExtraLargeCircularOpenGaugeImage
CLKComplicationTemplateGraphicExtraLargeCircularClosedGaugeText
CLKComplicationTemplateGraphicExtraLargeCircularClosedGaugeImage
CLKComplicationTemplateGraphicExtraLargeCircularStackText
CLKComplicationTemplateGraphicExtraLargeCircularStackImage

None of these are yet supported.

jschwalbe commented 3 years ago

I don't claim to understand many things, but I can copy an example and make changes. @zacwest can you suggest anything that I could sort of "template" this from?

zacwest commented 3 years ago

The watch complication code isn't super complex, but it's super confusing -- haven't had a good opportunity to refactor it. You can look at:

Adding to ComplicationTemplate (it will give you warnings in places that need more code added, mostly strings)
Add to the image sizes

Most of the other places -- in the UI, etc. -- will read from these values to decide what's editable. You'll need to extend the template definition in the template getter which might be a bit hairy for some of them. There's examples there which may work.