"Enter Adress Manually" doesn't work

[Moritz-Schmidt]

iOS device model, version and app version

Model Name: iPad Air (5th Generation) & iPhone 12 Pro Software Version: 18.0 (iPad) & 17.6 (iPhone) App version: 2024.9.3

Home Assistant Core Version 2024.10.0 (this should be irrelevant for the Issue)

Describe the bug While setting up the companion app you have to press the "Continue" button multiple times, this is inconvenient but not the main problem.

On the "Scanning for Servers" page nothing happens when pressing the "Enter Address Manually" button.

To Reproduce Open freshly installed Companion App, click on "continue", click on "Enter Adress Manually"

Expected behavior Being able to enter the Adress manually.

[karlbeecken]

Can reproduce, have the same issue

[aleks-mariusz]

ditto, just installed on ipad and stuck at 'Scanning for servers' and can't hit that button to manually enter address

[bgoncal]

I'm on it

[bgoncal]

Can one of you share a screen recording? On my iPhone it is working fine, I'll check iPad in a few hours

[Penait1]

I can reproduce it on my simulator. It throws the error [Error] [main] [OnboardingNavigationViewController.swift:129] show(_:sender:) > unknown sender Optional(<HomeAssistant.OnboardingScanningViewController: 0x108f12610>) wanted us to present: <HomeAssistant.OnboardingManualURLViewController: 0x129808a00>

I'm not sure why this condition exists near line 129 else if sender as? UIViewController == topViewController

Adding an explicit else clause for the OnboardingManualURLViewController fixes the issue but I'm not sure thats best practise

[aleks-mariusz]

Can one of you share a screen recording? On my iPhone it is working fine, I'll check iPad in a few hours

Here you go

https://github.com/user-attachments/assets/fa386391-bf58-4a20-ac59-9c81cf520e52

[bgoncal]

My PR above should handle that, I'll let you know it is available for test

[rgrae81]

iPhone 12 mini iOS 17.6 and 17.7 same Problem. Button is shown, react at pressing but no screen to enter appears.

iPhone 14 Pro iOS 17.6 is working fine.

[bgoncal]

I just submitted beta with the fix for it to Apple Review, it will come as 2024.9.4 (testflight)

[aleks-mariusz]

thanks for the lightning quick turnaround folks! curious how long the take it takes to show up in the app store for us mere mortals these days is?