home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
455 stars 521 forks source link

[DE] "add apple to shoppinglist" -> "add apple" added to shopping list #1941

Open Progaros opened 9 months ago

Progaros commented 9 months ago

"schreibe apfel auf die einkaufsliste" -> "schreibe apfel hinzugefügt" image

line 9 might be the problem here: https://github.com/home-assistant/intents/blob/7aeb3520b951e77f83f01b7c453df25766d41d8c/sentences/de/shopping_list_HassShoppingListAddItem.yaml#L9

switching with line 8 might work https://github.com/home-assistant/intents/blob/7aeb3520b951e77f83f01b7c453df25766d41d8c/sentences/de/shopping_list_HassShoppingListAddItem.yaml#L8

otherwise removal of line 9 doesn't seem to be a problem for me, since it's not even a real sentence <item> (auf|in) <meine_liste> [setzen|schreiben|nehmen] translates to to [add|write|take] <item> [to|on] <my_list>

dontinelli commented 8 months ago

I think one should change [setzen|schreiben|nehmen] to (setzen|schreiben|nehmen), as - like @Progaros said - without the verb it is no sentence.

mib1185 commented 5 months ago

yeah, that's actually an issue with the order of the sentences, fix is coming ....

nevermind ... i can't reproduce it - moreover it works correct

$ python3 -m script.intentfest parse --language de --sentence 'schreibe apfel auf die einkaufsliste'
{
  "text": "schreibe apfel auf die einkaufsliste",
  "match": true,
  "intent": "HassShoppingListAddItem",
  "slots": {
    "item": "apfel "
  },
  "context": {},
  "response_key": "item_added",
  "response": "apfel hinzugefügt"
}