search

home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
446 stars 509 forks source link

[FR] Add delay command in french #2261

Closed piitaya closed 3 months ago

piitaya commented 3 months ago

Add delay command in french

I also removed the requires_context for start timer to match english sentences.

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago
Walkthrough ## Walkthrough The updates enhance the French-language functionality for the Home Assistant's `HassStartTimer` command. This includes adding a command response in French, removing context constraints for timer intents, and introducing new timer commands with specific actions. ## Changes | Files | Change Summary | |----------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------| | `responses/fr/HassStartTimer.yaml` | Added new French response message under the `HassStartTimer` intent: “Commande reçue”. | | `sentences/fr/homeassistant_HassStartTimer.yaml` | Removed `requires_context` constraints and introduced new commands for setting timers with specific actions in Home Assistant integration. | | `tests/fr/homeassistant_HassStartTimer.yaml` | Added test case for starting a timer with the command to open the living room blinds after a specified time, covering variations in phrasing. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant System participant HomeAssistant User->>System: Set timer to open blinds in 5 minutes System->>HomeAssistant: Send command to start timer HomeAssistant->>System: Timer started, blinds will open in 5 minutes System->>User: Minuteur lancé. Commande reçue. ```
Recent review details **Configuration used: CodeRabbit UI** **Review profile: ASSERTIVE**
Commits Files that changed from the base of the PR and between 003e1e4de4ad95aa562ddaaa48d7c783c9981453 and e55e9bf395d15a98a5617ebd33a43065dbcf70c8.
Files selected for processing (3) * responses/fr/HassStartTimer.yaml (1 hunks) * sentences/fr/homeassistant_HassStartTimer.yaml (4 hunks) * tests/fr/homeassistant_HassStartTimer.yaml (1 hunks)
Additional comments not posted (3)
responses/fr/HassStartTimer.yaml (1)
`7-7`: **New command response added successfully.** The addition of `"Commande reçue"` under the `HassStartTimer` intent enhances feedback for specific user commands. Ensure that this new response integrates smoothly with the intent handling logic.
Verification successful --- **New command response added successfully.** The addition of `"Commande reçue"` under the `HassStartTimer` intent enhances feedback for specific user commands. The new response is correctly integrated with the intent handling logic and is referenced in the relevant test files. - `responses/fr/HassStartTimer.yaml`: The new response "Commande reçue" is properly added and used.
Scripts executed The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Description: Verify integration of new response with intent handling logic. # Test: Search for the intent usage. Expect: Proper integration with the intent. rg --type yaml 'HassStartTimer' --context 10 ``` Length of output: 71468
tests/fr/homeassistant_HassStartTimer.yaml (1)
`149-159`: **New test case for opening blinds after a delay added successfully.** This test case enhances the robustness of intent recognition for timer-based commands. Ensure that the test covers all necessary variations and integrates well with the existing test suite.
Verification successful --- **New test case for opening blinds after a delay added successfully.** The new test case for the `HassStartTimer` intent in `tests/fr/homeassistant_HassStartTimer.yaml` is well integrated and enhances the robustness of intent recognition for timer-based commands. The test case is present and consistent with the existing test suite. - **File:** `tests/fr/homeassistant_HassStartTimer.yaml` - **Lines:** 149-159
Scripts executed The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Description: Verify coverage and effectiveness of the new test case. # Test: Search for the test case usage. Expect: Comprehensive coverage and integration. rg --type yaml 'HassStartTimer' --context 10 ``` Length of output: 71468
sentences/fr/homeassistant_HassStartTimer.yaml (1)
`100-105`: **New sentence templates for timer commands with specific actions added successfully.** These templates enhance the flexibility of timer functionality by allowing users to specify actions. Ensure that these new templates integrate seamlessly with the intent recognition system.
Verification successful --- **New sentence templates for timer commands with specific actions added successfully.** These templates enhance the flexibility of timer functionality by allowing users to specify actions. The integration with the intent recognition system has been verified. - The `HassStartTimer` intent is present and well-integrated with the new sentence templates in the French file and other language files.
Scripts executed The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Description: Verify integration of new sentence templates with intent handling logic. # Test: Search for the sentence templates usage. Expect: Proper integration with the intent. rg --type yaml 'HassStartTimer' --context 10 ``` Length of output: 71468
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.