search

home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
429 stars 492 forks source link

[EN] Clean up some English templates #2263

Closed synesthesiam closed 4 weeks ago

synesthesiam commented 4 weeks ago

Avoid generating unnecessary/wrong text for some templates

Summary by CodeRabbit

coderabbitai[bot] commented 4 weeks ago
Walkthrough ## Walkthrough The updates refine the parsing of temperature expressions and streamline volume setting commands in English language sentences for specific intents. Temperature rules now accommodate more variations, such as the "°" symbol and the word "degrees" alongside the unit. Volume setting commands in the `HassSetVolume` intent are simplified by eliminating the optional "percent" specification, focusing on more direct volume adjustments. ## Changes | Files | Change Summary | |-----------------------------------------------|--------------------------------------------------------------------------------------------------| | `sentences/en/_common.yaml` | Updated temperature rule to handle "°" and "degrees" variations for better parsing. | | `sentences/en/media_player_HassSetVolume.yaml`| Simplified volume control commands by removing the optional "percent" specification. |
Recent review details **Configuration used: CodeRabbit UI** **Review profile: ASSERTIVE**
Commits Files that changed from the base of the PR and between f37d7a1f02292dab186cfba6ffb38cffc3998eb3 and 201c43f31d71b7a5aaae1f4475ae0e5e30a89b09.
Files selected for processing (2) * sentences/en/_common.yaml (1 hunks) * sentences/en/media_player_HassSetVolume.yaml (1 hunks)
Additional comments not posted (4)
sentences/en/media_player_HassSetVolume.yaml (3)
`6-9`: **Simplified volume control syntax approved.** The removal of `[percent]` simplifies the command structure, making it more user-friendly while still being clear. This change aligns with the PR objectives to clean up the templates. --- `13-16`: **Volume control syntax without percentage specifier is consistent and clear.** These changes maintain consistency across different contexts (like `area`) and simplify the interaction. Good job on ensuring that the simplification does not remove essential functionality. --- `21-26`: **Consistency in volume control commands across different domains.** The updates consistently apply the simplification across various domains such as `name` and `area`, ensuring a uniform user experience. This is crucial for maintaining a predictable interface.
sentences/en/_common.yaml (1)
`373-373`: **Enhanced temperature parsing rule is robust and flexible.** The updated rule to handle "°" and "degrees" along with the unit provides greater flexibility and accuracy in parsing temperature expressions. This improvement is significant for user interactions involving temperature controls.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.