search

home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
429 stars 492 forks source link

[DE] add degrees to HassClimateGetTemperature #2267

Closed andreasbrett closed 2 weeks ago

andreasbrett commented 4 weeks ago

Adds "Grad" to HassClimateGetTemperature responses. Much more natural sounding response for "Wie hoch ist die Temperatur im Wohnzimmer" (before: "24" / after: "24 Grad").

fixes #2216

Summary by CodeRabbit

coderabbitai[bot] commented 4 weeks ago
Walkthrough ## Walkthrough The recent changes enhance the clarity of temperature responses within the German localization of the HassClimateGetTemperature feature. Now, temperature values are appended with the unit "Grad," making them more informative. Corresponding test scenarios were updated to reflect this modification. ## Changes | File | Change Summary | |-----------------------------------------------------|----------------------------------------------------------------| | `responses/de/HassClimateGetTemperature.yaml` | Updated temperature response format to include "Grad". | | `tests/de/climate_HassClimateGetTemperature.yaml` | Modified test responses to include "Grad" after the temperature value. |
Recent review details **Configuration used: CodeRabbit UI** **Review profile: ASSERTIVE**
Commits Files that changed from the base of the PR and between 2a2c04a277ab1374f0ffdc38be7da38a2e85bbf8 and 5569f4476e7fca8842ae7565977bf467b859c84d.
Files selected for processing (2) * responses/de/HassClimateGetTemperature.yaml (1 hunks) * tests/de/climate_HassClimateGetTemperature.yaml (3 hunks)
Additional comments not posted (6)
responses/de/HassClimateGetTemperature.yaml (1)
`5-5`: **Approval of updated temperature response format.** The modification to append "Grad" to the temperature value in `HassClimateGetTemperature` responses is a clear improvement for German language users.
tests/de/climate_HassClimateGetTemperature.yaml (5)
`18-18`: **Consistency check for 'Wohnzimmer' test scenario.** The updated response "22 Grad" for the 'Wohnzimmer' test scenario correctly reflects the changes made in the response template. --- `26-26`: **Consistency check for 'Küche' test scenario.** The updated response "24 Grad" for the 'Küche' test scenario correctly reflects the changes made in the response template. --- `32-32`: **Consistency check for generic temperature query test scenario.** The updated response "22 Grad" for the generic temperature query test scenario correctly reflects the changes made in the response template. --- `43-43`: **Consistency check for 'Wohnzimmerthermostat' test scenario.** The updated response "22 Grad" for the 'Wohnzimmerthermostat' test scenario correctly reflects the changes made in the response template. --- `54-54`: **Consistency check for 'Thermostat im Wohnzimmer' test scenario.** The updated response "22 Grad" for the 'Thermostat im Wohnzimmer' test scenario correctly reflects the changes made in the response template.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
ChristophCaina commented 2 weeks ago

Thanks :) 👍