search

home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
429 stars 492 forks source link

[IT] Add support for media_player control #2275

Closed paolapersico1 closed 3 weeks ago

paolapersico1 commented 3 weeks ago

Add sentences, responses and tests for the following media_player-related intents for the Italian language:

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago
Walkthrough ## Walkthrough The changes introduce Italian language support for various Home Assistant media player intents such as `HassMediaNext`, `HassMediaPause`, `HassMediaPrevious`, `HassMediaUnpause`, and `HassSetVolume`. Each intent now includes Italian responses and intents necessary for controlling media playback. Additionally, new expansion rules and test cases in Italian are created to ensure the functionality of these updates. ## Changes | Files | Summary | |-----------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------| | `responses/it/HassMediaNext.yaml` | Added Italian response for the `HassMediaNext` intent: "Riproduco successivo." | | `responses/it/HassMediaPause.yaml` | Added Italian response for the `HassMediaPause` intent: "Messo in pausa." | | `responses/it/HassMediaPrevious.yaml` | Added Italian response for the `HassMediaPrevious` intent: "Riproduco precedente." | | `responses/it/HassMediaUnpause.yaml` | Added Italian response for the `HassMediaUnpause` intent: "Ripreso." | | `responses/it/HassSetVolume.yaml` | Added Italian response for the `HassSetVolume` intent: "Volume impostato." | | `sentences/it/_common.yaml` | Introduced expansion rule for "onto" in Italian, mapping to different prepositions like "su" for accurate translations. | | `sentences/it/media_player_HassMediaNext.yaml` | Added intents in Italian for controlling media playback: advancing to the next song, track, program, or episode. | | `sentences/it/media_player_HassMediaPause.yaml` | Added intents in Italian for pausing media across different contexts like songs, tracks, programs, and episodes. | | `sentences/it/media_player_HassMediaPrevious.yaml` | Added intents in Italian for media playback control: going back or repeating songs, tracks, episodes, etc. | | `sentences/it/media_player_HassMediaUnpause.yaml` | Added intents in Italian for resuming media playback in various contexts like music, programs, and episodes. | | `sentences/it/media_player_HassSetVolume.yaml` | Added intents in Italian for setting volume levels in media players for different contexts like names and areas. | | `tests/it/_fixtures.yaml` | Added a new entity "TV" to the entities list with its attributes for the testing setup. | | `tests/it/media_player_HassMediaNext.yaml` | Added test cases for `HassMediaNext` intent in Italian, covering commands for advancing to the next track or episode. | | `tests/it/media_player_HassMediaPause.yaml` | Added test cases for `HassMediaPause` intent in Italian, including pausing TV, general commands, and areas like "Soggiorno." | | `tests/it/media_player_HassMediaPrevious.yaml` | Added test cases for `HassMediaPrevious` intent in Italian, focusing on commands to go back or repeat media playback. | | `tests/it/media_player_HassMediaUnpause.yaml` | Added test cases for `HassMediaUnpause` intent in Italian, including resuming playback in contexts like TV and living room. | | `tests/it/media_player_HassSetVolume.yaml` | Added test cases for `HassSetVolume` intent in Italian, defining commands to set volume levels for different contexts. |
Recent review details **Configuration used: CodeRabbit UI** **Review profile: ASSERTIVE**
Commits Files that changed from the base of the PR and between f892676d6f696f6ed8a529914ac999b56fbb6539 and 1cf4a2622726013de6497ea61a1d556162b846c9.
Files selected for processing (17) * responses/it/HassMediaNext.yaml (1 hunks) * responses/it/HassMediaPause.yaml (1 hunks) * responses/it/HassMediaPrevious.yaml (1 hunks) * responses/it/HassMediaUnpause.yaml (1 hunks) * responses/it/HassSetVolume.yaml (1 hunks) * sentences/it/_common.yaml (1 hunks) * sentences/it/media_player_HassMediaNext.yaml (1 hunks) * sentences/it/media_player_HassMediaPause.yaml (1 hunks) * sentences/it/media_player_HassMediaPrevious.yaml (1 hunks) * sentences/it/media_player_HassMediaUnpause.yaml (1 hunks) * sentences/it/media_player_HassSetVolume.yaml (1 hunks) * tests/it/_fixtures.yaml (1 hunks) * tests/it/media_player_HassMediaNext.yaml (1 hunks) * tests/it/media_player_HassMediaPause.yaml (1 hunks) * tests/it/media_player_HassMediaPrevious.yaml (1 hunks) * tests/it/media_player_HassMediaUnpause.yaml (1 hunks) * tests/it/media_player_HassSetVolume.yaml (1 hunks)
Additional comments not posted (17)
responses/it/HassMediaUnpause.yaml (1)
`1-5`: **LGTM!** The Italian response for the `HassMediaUnpause` intent is correctly defined as "Ripreso".
responses/it/HassMediaPause.yaml (1)
`1-5`: **LGTM!** The Italian response for the `HassMediaPause` intent is correctly defined as "Messo in pausa".
responses/it/HassSetVolume.yaml (1)
`1-5`: **LGTM!** The Italian response for the `HassSetVolume` intent is correctly defined as "Volume impostato".
responses/it/HassMediaNext.yaml (1)
`1-5`: **LGTM!** The Italian response for the `HassMediaNext` intent is correctly defined as "Riproduco successivo".
responses/it/HassMediaPrevious.yaml (1)
`1-5`: **Translation Accuracy Check** The translation "Riproduco precedente" for the `HassMediaPrevious` intent seems accurate and appropriate.
sentences/it/media_player_HassMediaUnpause.yaml (1)
`1-17`: **Ensure Contextual Appropriateness and Coverage** The sentences for the `HassMediaUnpause` intent appear to cover various use cases like resuming music, programs, and media players. The structure and context seem appropriate.
sentences/it/media_player_HassSetVolume.yaml (1)
`1-17`: **Ensure Contextual Appropriateness and Coverage** The sentences for the `HassSetVolume` intent appear to cover various use cases like setting the volume for specific media players and areas. The structure and context seem appropriate.
sentences/it/media_player_HassMediaPause.yaml (1)
`1-17`: **Ensure Contextual Appropriateness and Coverage** The sentences for the `HassMediaPause` intent appear to cover various use cases like pausing music, programs, and media players. The structure and context seem appropriate.
tests/it/media_player_HassMediaUnpause.yaml (1)
`1-30`: **Comprehensive Test Coverage for `HassMediaUnpause`.** The test cases cover various sentences and contexts for unpausing media in Italian. They are well-structured and ensure the intent works correctly for different scenarios.
tests/it/media_player_HassMediaPause.yaml (1)
`1-30`: **Comprehensive Test Coverage for `HassMediaPause`.** The test cases cover various sentences and contexts for pausing media in Italian. They are well-structured and ensure the intent works correctly for different scenarios.
tests/it/media_player_HassSetVolume.yaml (1)
`1-45`: **Comprehensive Test Coverage for `HassSetVolume`.** The test cases cover various sentences and contexts for setting the volume in Italian. They are well-structured and ensure the intent works correctly for different scenarios.
tests/it/media_player_HassMediaPrevious.yaml (1)
`1-45`: **Comprehensive Test Coverage for `HassMediaPrevious`.** The test cases cover various sentences and contexts for playing the previous media item in Italian. They are well-structured and ensure the intent works correctly for different scenarios.
tests/it/_fixtures.yaml (1)
`72-77`: **LGTM!** The new entity "TV" with specific attributes has been added correctly.
tests/it/media_player_HassMediaNext.yaml (1)
`1-66`: **LGTM!** The test cases for the `HassMediaNext` intent in Italian are comprehensive and cover various sentences, contexts, and expected responses.
sentences/it/media_player_HassMediaPrevious.yaml (1)
`1-30`: **LGTM!** The sentences for the `HassMediaPrevious` intent in Italian are comprehensive and cover various ways to trigger the intent with different contexts.
sentences/it/media_player_HassMediaNext.yaml (1)
`1-54`: **LGTM!** The sentences for the `HassMediaNext` intent in Italian are comprehensive and cover various ways to trigger the intent with different contexts.
sentences/it/_common.yaml (1)
`387-387`: **Addition of expansion rule for "onto" looks good!** The new expansion rule for "onto" follows the correct format and integrates well with the existing rules.
--- > [!TIP] >
> Early access features: enabled > > We are currently testing the following features in early access: > > - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. > > Note: > - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. > - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. > - OSS projects are currently opted into early access features by default. > >

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.