search

home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
429 stars 492 forks source link

[de] Weather sentences without a name #2278

Closed johanneswuerbach closed 1 week ago

johanneswuerbach commented 3 weeks ago

Align with the en version and add a whether sentence without a name.

https://github.com/home-assistant/intents/blob/main/sentences/en/weather_HassGetWeather.yaml#L5-L6

Summary by CodeRabbit

home-assistant[bot] commented 3 weeks ago

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

coderabbitai[bot] commented 3 weeks ago
Walkthrough ## Walkthrough The changes introduced a new sentence variant "wie ist das Wetter" to the `HassGetWeather` intent in German, alongside updating the test file to include a new test case for this sentence variant. These updates enhance the language comprehension and testing coverage for weather-related queries in German. ## Changes | Files | Change Summary | |--------------------------------------|--------------------------------------------------------------------------------------------------------------| | `sentences/de/weather_HassGetWeather.yaml` | Added a new sentence variant "wie ist das Wetter" for the `HassGetWeather` intent in German. | | `tests/de/weather_HassGetWeather.yaml` | Added a new test case for the `HassGetWeather` intent to validate responses for the newly added sentence variant. |
Recent review details **Configuration used: CodeRabbit UI** **Review profile: ASSERTIVE**
Commits Files that changed from the base of the PR and between 7c0e2c649464df14eb386b26abe1c10cb1787471 and f367ea27b04db610ba887b21265085f87ba75447.
Files selected for processing (2) * sentences/de/weather_HassGetWeather.yaml (1 hunks) * tests/de/weather_HassGetWeather.yaml (1 hunks)
Additional comments not posted (2)
sentences/de/weather_HassGetWeather.yaml (1)
`5-6`: **Addition of a new sentence variant is appropriate.** The new sentence "wie ist[ das] Wetter" aligns with the existing structure and enhances the coverage of the `HassGetWeather` intent.
tests/de/weather_HassGetWeather.yaml (1)
`3-8`: **New test cases are correctly formulated.** The new test cases for the sentence variants "wie ist das Wetter" and "wie ist Wetter" ensure that the `HassGetWeather` intent responds correctly. The responses are consistent with the existing tests.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
andreasbrett commented 2 weeks ago

@johanneswuerbach I could not fork your fork ;) So please find an implementation of the test here.

Add this to tests/de/weather_HassGetWeather.yaml

  - sentences:
      - "wie ist das Wetter"
      - "wie ist Wetter"
    intent:
      name: HassGetWeather
    response: 8 °C und regnerisch
johanneswuerbach commented 2 weeks ago

Thanks folks, added the test.

andreasbrett commented 1 week ago

@mib1185 could you please review this?