search

home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
429 stars 492 forks source link

[SL] added CancelTimer #2279

Closed andrejs2 closed 3 weeks ago

andrejs2 commented 3 weeks ago

Added Slovenian sentences and test for hassCancelTimer

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago
Walkthrough ## Walkthrough The recent updates introduce responses and testing for timer cancelation in the Slovenian language. Key changes include new files for responses and intents related to canceling timers, additional error messages for various user authentication and device states, as well as new timer fixtures for testing. ## Changes | Files | Change Summaries | |----------------------------------------------|-----------------------------------------------------------------------| | `responses/sl/HassCancelTimer.yaml` | Introduced a response message for canceling a timer in Slovenian, stating "Časovnik preklican." | | `sentences/sl/_common.yaml` | Added and modified error messages related to user authentication, device classes, entity states, and timers. | | `tests/sl/_fixtures.yaml` | Added new timer entries with specific attributes for detailed testing. | | `sentences/sl/homeassistant_HassCancelTimer.yaml` | Introduced intent definitions for canceling timers with various sentence patterns in Slovenian. | | `tests/sl/homeassistant_HassCancelTimer.yaml` | Added test cases for different scenarios of timer cancelation in Slovenian. | ## Sequence Diagram(s) Not applicable for these changes.
Recent review details **Configuration used: CodeRabbit UI** **Review profile: ASSERTIVE**
Commits Files that changed from the base of the PR and between 8fd7f84685c56fba59329c027a4165495838c132 and 2d85c2b8acc3feb5b3db3ea3b5ebbdd539c4655b.
Files selected for processing (5) * responses/sl/HassCancelTimer.yaml (1 hunks) * sentences/sl/_common.yaml (4 hunks) * sentences/sl/homeassistant_HassCancelTimer.yaml (1 hunks) * tests/sl/_fixtures.yaml (1 hunks) * tests/sl/homeassistant_HassCancelTimer.yaml (1 hunks)
Additional comments not posted (9)
responses/sl/HassCancelTimer.yaml (1)
`1-6`: **LGTM!** The file correctly defines a Slovenian response for canceling a timer.
sentences/sl/homeassistant_HassCancelTimer.yaml (1)
`1-16`: **LGTM!** The file correctly defines various sentence structures for the `HassCancelTimer` intent in Slovenian.
tests/sl/homeassistant_HassCancelTimer.yaml (2)
`1-45`: **LGTM!** The file correctly adds various test cases for the `HassCancelTimer` intent in Slovenian. --- `46-53`: **Commented-out test case.** There is a commented-out test case for canceling a kitchen timer. Ensure this is intentional and that it is tracked for future implementation if necessary.
sentences/sl/_common.yaml (3)
`4-7`: **LGTM!** The file correctly adds general error messages in Slovenian. --- `11-21`: **LGTM!** The file correctly adds error messages for user authentication states, device classes, and entities in Slovenian. --- `40-42`: **LGTM!** The file correctly adds error messages for timer-related issues in Slovenian.
tests/sl/_fixtures.yaml (2)
`865-870`: **LGTM! Timer entry is correct and complete.** The second timer entry has all necessary attributes: `name`, `start_minutes`, `total_seconds_left`, `rounded_hours_left`, `rounded_minutes_left`, and `rounded_seconds_left`. --- `871-876`: **LGTM! Timer entry is correct and complete.** The third timer entry has all necessary attributes: `area`, `start_minutes`, `total_seconds_left`, `rounded_hours_left`, `rounded_minutes_left`, and `rounded_seconds_left`.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.