Closed TheFes closed 2 weeks ago
sentences/nl/climate_HassClimateSetTemperature.yaml (4)
`6-6`: **LGTM!** The sentence pattern correctly uses `` and optional elements. --- `7-7`: **LGTM!** The sentence pattern correctly uses ` ` and optional elements. --- `8-8`: **LGTM!** The sentence pattern correctly uses ` ` and optional elements. --- `9-9`: **LGTM!** The sentence pattern correctly uses ``, "temperatuur", and optional elements. tests/nl/climate_HassClimateSetTemperature.yaml (10)
`4-4`: **LGTM!** The test sentence correctly reflects the new pattern. --- `5-5`: **LGTM!** The test sentence correctly reflects the new pattern. --- `6-6`: **LGTM!** The test sentence correctly reflects the new pattern. --- `7-7`: **LGTM!** The test sentence correctly reflects the new pattern. --- `8-8`: **LGTM!** The test sentence correctly reflects the new pattern. --- `15-15`: **LGTM!** The test sentence correctly reflects the new pattern. --- `16-16`: **LGTM!** The test sentence correctly reflects the new pattern. --- `17-17`: **LGTM!** The test sentence correctly reflects the new pattern. --- `18-18`: **LGTM!** The test sentence correctly reflects the new pattern. --- `19-19`: **LGTM!** The test sentence correctly reflects the new pattern.sentences/nl/_common.yaml (1)
`440-440`: **LGTM!** The `numeric_value_set` entity remains unchanged.
Could you have a look at this one @frenck Inspired by your PR, I just started at the top of the list to see if everything aligns with EN.
<numeric_value_set>
zou je de temperatuur in de woonkamer op 19 graden willen zetten
<name>
as target, as this isn't added in EN, and doesn't seem to be working in my tests in a production system.Compared to EN I did add the really short intents like
woonkamer 19 graden
ortemperatuur 19 graden
. I didn't makegraden
optional there to avoid conflicts with other intents.Summary by CodeRabbit
New Features
Improvements