search

home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
429 stars 492 forks source link

[DE] add variants to HassMediaPrevious #2291

Closed andreasbrett closed 2 weeks ago

andreasbrett commented 2 weeks ago

added more variants as proposed in https://github.com/home-assistant/intents/pull/2254#pullrequestreview-2142758441

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago
Walkthrough ## Walkthrough The changes enhance the German language processing for media playback commands, focusing on refining directional phrases and commands. Key updates include an expansion rule for "zu dem" to "zum" and the addition of the "wiederhole" command for repeating actions. These updates improve the flexibility, accuracy, and testing coverage of the media control commands, particularly for the `HassMediaPrevious` intent, enabling commands for both starting and repeating the previous track. ## Changes | Files/Group | Change Summary | |-----------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------| | `sentences/de/_common.yaml` | Introduced an expansion rule for "zu dem" to "zum" and included the command "wiederhole" for repeating actions. | | `sentences/de/media_player_HassMediaPrevious.yaml` | Enhanced sentence structures for the `HassMediaPrevious` intent to include the "wiederhole" command for repeating the previous song. | | `tests/de/media_player_HassMediaPrevious.yaml` | Updated tests to add phrases for repeating and going back to the last song or title on TV, in the living room, and in a generic context to enhance test coverage.|
Recent review details **Configuration used: CodeRabbit UI** **Review profile: ASSERTIVE**
Commits Files that changed from the base of the PR and between e1b3a88217efba4b4d7ce315a4b756a3141c2c6e and 4afa56992f71d27e8630da4c91779bbd46df2387.
Files selected for processing (2) * sentences/de/_common.yaml (2 hunks) * tests/de/media_player_HassMediaPrevious.yaml (3 hunks)
Additional comments not posted (5)
tests/de/media_player_HassMediaPrevious.yaml (3)
`4-14`: **LGTM! The new test sentences for the TV context are well-covered.** The added sentences handle various ways users might phrase the command for repeating or going back to the last title or song on TV. --- `35-39`: **LGTM! The new test sentences for the Wohnzimmer context are well-covered.** The added sentences handle various ways users might phrase the command for repeating or going back to the last title or song in the living room. --- `58-62`: **LGTM! The new test sentences for the generic context are well-covered.** The added sentences handle various ways users might phrase the command for repeating or going back to the last title or song in a generic context.
sentences/de/_common.yaml (2)
`276-276`: **LGTM! The handling of the contraction "zu dem" to "zum" is correctly refined.** The change ensures the contraction is correctly handled. --- `340-340`: **LGTM! The command "wiederhole" for repeating actions is correctly incorporated.** The change ensures the command is correctly handled.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.