home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
429 stars 492 forks source link

[SL] Added HassStartTimer #2293

Closed andrejs2 closed 2 weeks ago

andrejs2 commented 2 weeks ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago
Walkthrough ## Walkthrough This update introduces Slovenian language support for the `HassStartTimer` intent, enhancing the functionality for setting timers within Home Assistant. Key files include new YAML configurations for timer expressions, intent definitions, and test cases, focusing on diverse ways to specify timer durations in minutes and hours, including fractional and combined time units. ## Changes | Files | Change Summary | |-------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------| | `responses/sl/HassStartTimer.yaml` | Added Slovenian responses for the `HassStartTimer` intent, including default and command responses. | | `sentences/sl/_common.yaml` | Refined expressions for timer durations in minutes and hours, adding variations to improve clarity and flexibility. | | `sentences/sl/homeassistant_HassStartTimer.yaml` | Introduced the `HassStartTimer` intent in Slovenian, enabling various expressions for starting timers within Home Assistant. | | `tests/sl/homeassistant_HassStartTimer.yaml` | Added test cases for the `HassStartTimer` intent in Slovenian, validating intent recognition and slot extraction for timer settings in various configurations. |

Recent review details **Configuration used: CodeRabbit UI** **Review profile: ASSERTIVE**
Commits Files that changed from the base of the PR and between 0b3065df62d83a19c54557636714891ae49df599 and aeac3ff09349a09be80b366a96717771abb43aa8.
Files selected for processing (4) * responses/sl/HassStartTimer.yaml (1 hunks) * sentences/sl/_common.yaml (2 hunks) * sentences/sl/homeassistant_HassStartTimer.yaml (1 hunks) * tests/sl/homeassistant_HassStartTimer.yaml (1 hunks)
Additional comments not posted (46)
responses/sl/HassStartTimer.yaml (7)
`1-1`: **YAML document start marker is correct.** --- `2-2`: **Language specification is correct.** --- `3-3`: **Responses section start is correct.** --- `4-4`: **Intents subsection start is correct.** --- `5-5`: **HassStartTimer intent start is correct.** --- `6-6`: **Default response for HassStartTimer is correct.** The response "Časovnik začet" is appropriate for indicating that the timer has started. --- `7-7`: **Command response for HassStartTimer is correct.** The response "Ukaz prejet" is appropriate for acknowledging that the command has been received.
sentences/sl/homeassistant_HassStartTimer.yaml (21)
`1-1`: **YAML document start marker is correct.** --- `2-2`: **Language specification is correct.** --- `3-3`: **Intents section start is correct.** --- `4-4`: **HassStartTimer intent start is correct.** --- `5-5`: **Data section start for HassStartTimer is correct.** --- `6-6`: **Sentences list start is correct.** --- `7-7`: **Sentence pattern for HassStartTimer is correct.** The pattern covers various ways to start a timer with a duration. --- `8-8`: **Sentence pattern for HassStartTimer is correct.** The pattern covers another way to start a timer with a duration. --- `9-9`: **Sentence pattern for HassStartTimer is correct.** The pattern covers another way to start a timer with a duration. --- `10-10`: **Sentence pattern for HassStartTimer is correct.** The pattern covers another way to start a timer with a duration. --- `11-11`: **Sentence pattern for HassStartTimer is correct.** The pattern covers another way to start a timer with a duration. --- `12-12`: **Sentence pattern for HassStartTimer is correct.** The pattern covers another way to start a timer with a duration. --- `13-13`: **Sentence pattern for HassStartTimer is correct.** The pattern covers another way to start a timer with a duration. --- `14-14`: **Sentence pattern for HassStartTimer is correct.** The pattern covers another way to start a timer with a duration. --- `15-15`: **Sentence pattern for HassStartTimer is correct.** The pattern covers another way to start a timer with a duration and name. --- `16-16`: **Sentence pattern for HassStartTimer is correct.** The pattern covers another way to start a timer with a duration and name. --- `17-17`: **Sentence pattern for HassStartTimer is correct.** The pattern covers another way to start a timer with a duration and name. --- `18-18`: **Another sentences list start is correct.** --- `19-19`: **Sentence pattern for HassStartTimer is correct.** The pattern covers a way to start a timer with a command and duration. --- `20-20`: **Sentence pattern for HassStartTimer is correct.** The pattern covers another way to start a timer with a command and duration. --- `21-21`: **Response type specification is correct.**
tests/sl/homeassistant_HassStartTimer.yaml (14)
`4-13`: **LGTM!** The test case for setting a 10-minute timer is well-defined. --- `14-26`: **LGTM!** The test case for setting a 1-hour timer is well-defined. --- `28-38`: **LGTM!** The test case for setting a 5-minute and 30-second timer is well-defined. --- `40-51`: **LGTM!** The test case for setting a 30-second timer is well-defined. --- `53-63`: **LGTM!** The test case for setting a 1-hour and 30-minute timer is well-defined. --- `65-74`: **LGTM!** The test case for setting a 30-minute timer is well-defined. --- `76-87`: **LGTM!** The test case for setting a 1-hour and 15-minute timer is well-defined. --- `89-100`: **LGTM!** The test case for setting a 1-hour and 30-second timer is well-defined. --- `102-114`: **LGTM!** The test case for setting a 1-hour, 15-minute, and 30-second timer is well-defined. --- `116-126`: **LGTM!** The test case for setting a 5-minute timer is well-defined. --- `128-143`: **LGTM!** The test case for setting a 5-minute timer named "pizza" is well-defined. --- `145-156`: **LGTM!** The test case for setting a 5-minute and 10-second timer is well-defined. --- `158-168`: **LGTM!** The test case for setting a 45-second timer is well-defined. --- `170-180`: **LGTM!** The test case for setting a 5-minute timer to open the garage door is well-defined.
sentences/sl/_common.yaml (4)
`409-409`: **LGTM!** The addition of "startaj" to the `timer_set` pattern adds flexibility. --- `413-413`: **LGTM!** The update to the `timer_duration_minutes` pattern adds flexibility to the duration expressions. --- `414-414`: **LGTM!** The update to the `timer_duration_hours` pattern adds flexibility to the duration expressions. --- `415-415`: **LGTM!** The update to the `timer_duration` pattern ensures consistency with the new `timer_duration_minutes` and `timer_duration_hours` patterns.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.