search

home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
429 stars 492 forks source link

[SL] Added Hass_Decrease, Increase, Pause and UnpauseTimer #2295

Closed andrejs2 closed 2 weeks ago

andrejs2 commented 2 weeks ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago
Walkthrough ## Walkthrough The introduced files add Slovenian language support for Home Assistant timer functionalities, allowing users to decrease, increase, and unpause timers through various sentence patterns and responses. This includes new response configurations, sentence variations, and corresponding test cases. ## Changes | File Path | Change Summary | |---------------------------------------------|--------------------------------------------------------------------------------------------------| | responses/sl/HassDecreaseTimer.yaml | Added response configuration for decreasing timers in Slovenian ("Časovnik posodobljen"). | | responses/sl/HassIncreaseTimer.yaml | Added response configuration for increasing timers in Slovenian ("Časovnik posodobljen"). | | responses/sl/HassUnpauseTimer.yaml | Added response configuration for unpausing timers in Slovenian. | | sentences/sl/homeassistant_HassDecreaseTimer.yaml | Introduced sentence variations for decreasing timers in Slovenian. | | sentences/sl/homeassistant_HassIncreaseTimer.yaml | Introduced sentence variations for increasing timers in Slovenian. | | sentences/sl/homeassistant_HassUnpauseTimer.yaml | Added intent variations for resuming timers in Slovenian. | | tests/sl/homeassistant_HassDecreaseTimer.yaml | Added test cases for decreasing timers with different configurations in Slovenian. | | tests/sl/homeassistant_HassIncreaseTimer.yaml | Added test cases for increasing timers with different configurations in Slovenian. | | tests/sl/homeassistant_HassUnpauseTimer.yaml | Added test cases for resuming timers based on various user inputs in Slovenian. |
Recent review details **Configuration used: CodeRabbit UI** **Review profile: ASSERTIVE**
Commits Files that changed from the base of the PR and between 3feb8a632e4665dc423b6bf9e9fab82edc4e6551 and 3f22c11d102c96303ce58738b104224a59fae609.
Files selected for processing (9) * responses/sl/HassDecreaseTimer.yaml (1 hunks) * responses/sl/HassIncreaseTimer.yaml (1 hunks) * responses/sl/HassUnpauseTimer.yaml (1 hunks) * sentences/sl/homeassistant_HassDecreaseTimer.yaml (1 hunks) * sentences/sl/homeassistant_HassIncreaseTimer.yaml (1 hunks) * sentences/sl/homeassistant_HassUnpauseTimer.yaml (1 hunks) * tests/sl/homeassistant_HassDecreaseTimer.yaml (1 hunks) * tests/sl/homeassistant_HassIncreaseTimer.yaml (1 hunks) * tests/sl/homeassistant_HassUnpauseTimer.yaml (1 hunks)
Additional comments not posted (13)
responses/sl/HassDecreaseTimer.yaml (1)
`1-6`: **Ensure consistency in the Slovenian response message.** The response message for the `HassDecreaseTimer` intent is "Časovnik posodobljen." Verify that this message is consistent with other related intent responses (e.g., `HassUnpauseTimer`, `HassIncreaseTimer`) to maintain uniformity.
sentences/sl/homeassistant_HassUnpauseTimer.yaml (1)
`1-16`: **Ensure completeness and correctness of intent variations.** The intent variations for `HassUnpauseTimer` seem comprehensive, covering various ways users might express the intent. Ensure that all possible variations are included and correctly formatted.
tests/sl/homeassistant_HassUnpauseTimer.yaml (3)
`4-9`: **LGTM!** The test case for unpausing a general timer is well-formed and covers multiple sentence variations. --- `11-18`: **LGTM!** The test case for unpausing a timer with a specific start hour is well-formed and covers multiple sentence variations. --- `20-33`: **LGTM!** The test case for unpausing a timer with a specific name is well-formed and covers multiple sentence variations.
tests/sl/homeassistant_HassIncreaseTimer.yaml (3)
`4-11`: **LGTM!** The test case for increasing a general timer by minutes is well-formed and covers multiple sentence variations. --- `13-23`: **LGTM!** The test case for increasing a timer with a specific start hour by minutes is well-formed and covers multiple sentence variations. --- `25-36`: **LGTM!** The test case for increasing a timer with a specific name by minutes is well-formed and covers multiple sentence variations.
tests/sl/homeassistant_HassDecreaseTimer.yaml (3)
`4-11`: **LGTM!** The test case for decreasing a general timer by minutes is well-formed and covers multiple sentence variations. --- `13-23`: **LGTM!** The test case for decreasing a timer with a specific start hour by minutes is well-formed and covers multiple sentence variations. --- `25-41`: **LGTM!** The test case for decreasing a timer with a specific name by minutes is well-formed and covers multiple sentence variations.
sentences/sl/homeassistant_HassIncreaseTimer.yaml (1)
`4-26`: **LGTM!** The sentence variations for increasing a timer are well-formed and cover multiple ways a user might request to increase a timer.
sentences/sl/homeassistant_HassDecreaseTimer.yaml (1)
`1-2`: **Header and Language Declaration Approved.** The header and language declaration are correctly set to Slovenian.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.