search

home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
444 stars 502 forks source link

Add HassGetDate and HassGetTime #2300

Closed synesthesiam closed 1 month ago

synesthesiam commented 1 month ago

Add English sentences for two new intents (not yet supported in HA):

Note that strftime should not be used since it will use the machine's current locale and not the intent's language.

coderabbitai[bot] commented 1 month ago
Walkthrough ## Walkthrough The update introduces new intents, `HassGetCurrentDate` and `HassGetCurrentTime`, to retrieve the current date and time, respectively. It includes changes across various files to support these intents, adds response templates, and integrates validation and testing for natural language queries related to date and time. ## Changes | File(s) | Summary | |---------|---------| | `intents.yaml` | Added intents `HassGetCurrentDate` and `HassGetCurrentTime` with descriptions. | | `responses/en/HassGetCurrentDate.yaml`, `responses/en/HassGetCurrentTime.yaml` | Introduced response templates for new intents in English. | | `script/intentfest/generate_day_ordinals.py` | Added functionality to generate day ordinals mapped to words. | | `script/intentfest/util.py` | Included `generate_day_ordinals` in the accepted commands list. | | `script/intentfest/validate.py` | Added initialization of date and time slots using `datetime.now()` for validation. | | `sentences/en/homeassistant_HassGetCurrentDate.yaml`, `sentences/en/homeassistant_HassGetCurrentTime.yaml` | Introduced intents in English for obtaining the current date and time. | | `shared/__init__.py` | Imported `datetime` and initialized `_TEST_DATETIME`, setting it for date/time slots. | | `tests/en/homeassistant_HassGetCurrentDate.yaml`, `tests/en/homeassistant_HassGetCurrentTime.yaml` | Added test cases for querying the current date and time in natural language. | ## Sequence Diagram(s) Silently ignored generating this section as the changes do not significantly alter control flows or add complex new features.
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 45b591c790c68a6e6e601aee66bc6a2eb182c067 and 5f22cb6ef59ce7f0acb58fbae6d8842ddbd5d2eb.
Files selected for processing (7) * intents.yaml (1 hunks) * responses/en/HassGetCurrentDate.yaml (1 hunks) * responses/en/HassGetCurrentTime.yaml (1 hunks) * sentences/en/homeassistant_HassGetCurrentDate.yaml (1 hunks) * sentences/en/homeassistant_HassGetCurrentTime.yaml (1 hunks) * tests/en/homeassistant_HassGetCurrentDate.yaml (1 hunks) * tests/en/homeassistant_HassGetCurrentTime.yaml (1 hunks)
Files skipped from review due to trivial changes (6) * responses/en/HassGetCurrentDate.yaml * responses/en/HassGetCurrentTime.yaml * sentences/en/homeassistant_HassGetCurrentDate.yaml * sentences/en/homeassistant_HassGetCurrentTime.yaml * tests/en/homeassistant_HassGetCurrentDate.yaml * tests/en/homeassistant_HassGetCurrentTime.yaml
Files skipped from review as they are similar to previous changes (1) * intents.yaml
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
home-assistant[bot] commented 1 month ago

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.