search

home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
444 stars 502 forks source link

[SL] added Current Date and Current Time #2303

Closed andrejs2 closed 1 month ago

andrejs2 commented 1 month ago

Added Slovenian translation for HassCurrentDate and HassCurrentTime

Response for current time maybe not correct or perfect for Slovenian time format...needs change. Example: 01:02 - > 1:02 TODO: modify response file for CurrentTime

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago
Walkthrough ## Walkthrough The changes introduce Slovenian language support for Home Assistant intents related to retrieving the current date and time. This includes new response files, intent definitions, and corresponding test cases for both `HassGetCurrentDate` and `HassGetCurrentTime` intents. ## Changes | File Path | Change Summary | |------------------------------------------------|-------------------------------------------------------------------------------| | responses/sl/HassGetCurrentDate.yaml | Introduces response logic for `HassGetCurrentDate` in Slovenian, formatting the current date. | | responses/sl/HassGetCurrentTime.yaml | Adds response logic for `HassGetCurrentTime` in Slovenian, formatting the current time. | | sentences/sl/homeassistant_HassGetCurrentDate.yaml | Introduces intent `HassGetCurrentDate` in Slovenian for recognizing queries about the current date. | | sentences/sl/homeassistant_HassGetCurrentTime.yaml | Adds Slovenian language intent variations for retrieving the current time in Home Assistant. | | tests/sl/homeassistant_HassGetCurrentDate.yaml | Introduces Slovenian test cases for the `HassGetCurrentDate` intent, ensuring correct date retrieval. | | tests/sl/homeassistant_HassGetCurrentTime.yaml | Adds Slovenian test cases for the `HassGetCurrentTime` intent, ensuring correct time retrieval. |
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between f9f8cc0acf416a6aaba509b81e911cd1d425ea97 and 940a3eae87326396899097217c8dbc9d1c596dd1.
Files selected for processing (6) * responses/sl/HassGetCurrentDate.yaml (1 hunks) * responses/sl/HassGetCurrentTime.yaml (1 hunks) * sentences/sl/homeassistant_HassGetCurrentDate.yaml (1 hunks) * sentences/sl/homeassistant_HassGetCurrentTime.yaml (1 hunks) * tests/sl/homeassistant_HassGetCurrentDate.yaml (1 hunks) * tests/sl/homeassistant_HassGetCurrentTime.yaml (1 hunks)
Files skipped from review due to trivial changes (5) * responses/sl/HassGetCurrentDate.yaml * sentences/sl/homeassistant_HassGetCurrentDate.yaml * sentences/sl/homeassistant_HassGetCurrentTime.yaml * tests/sl/homeassistant_HassGetCurrentDate.yaml * tests/sl/homeassistant_HassGetCurrentTime.yaml
Additional comments not posted (3)
responses/sl/HassGetCurrentTime.yaml (3)
`1-4`: **Initial setup looks good.** The language and intent declaration are correctly set up. --- `5-8`: **Response logic is correct.** The Jinja2 templating correctly formats the hour and minute as two-digit strings. --- `9-16`: **Consider addressing the TODO for Slovenian time format.** The commented-out section suggests an alternative time format with AM/PM notation. Ensure that the TODO item regarding the correct Slovenian time format is addressed. This might involve updating the response logic to ensure times like "01:02" are displayed correctly.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.