search

home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
453 stars 516 forks source link

[SL] HassTurnOff, lightHassLightSet fix #2343

Closed andrejs2 closed 3 months ago

andrejs2 commented 3 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago
Walkthrough ## Walkthrough The recent changes streamline the handling of light and device control intents in the home automation system. Key modifications include simplifying response messages for the `HassTurnOff` intent, enhancing input recognition for turning off devices, and improving the specificity of commands related to light control. These adjustments aim to make user interactions more intuitive and efficient, promoting a clearer understanding of commands within the system. ## Changes | Files | Change Summary | |-------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `responses/sl/HassTurnOff.yaml` | Simplified default response to "Izklopljeno" and commented out specific naming conventions, enhancing generality in responses. | | `sentences/sl/homeassistant_HassTurnOff.yaml` | Updated intent with regex-based patterns for broader input recognition and commented out the response field, refining operational context and intent handling. | | `sentences/sl/light_HassSet.yaml` | Introduced a new intent for brightness settings with more nuanced sentence structures and added expansion rules for context-specific references. | | `sentences/sl/light_HassTurnOff.yaml` | Commented out an inactive intent pattern for turning off lights, indicating a shift towards simplified command handling. | | `tests/sl/_fixtures.yaml` | Modified entity names for clarity, changing "spaln(a|o|e) luč[ka|ko|i]" to "luč[ko|i] v spalnici" and simplifying "luč[i|ke|ki] na balkonu" to "balkon". | | `tests/sl/homeassistant_HassTurnOff.yaml` | Updated test cases to focus on bedroom lighting, standardizing responses to "Izklopljeno," reflecting a simplification in response logic. | | `tests/sl/light_HassLightSet.yaml` | Enhanced clarity in lighting commands, replacing "spalno luč" with "luč v spalnici" and adding "area" context to improve command specificity related to brightness adjustments. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant IntentSystem participant LightControl participant ResponseGenerator User->>IntentSystem: "Izklopi luč v spalnici" IntentSystem->>LightControl: Turn off light in bedroom LightControl-->>ResponseGenerator: Send "Izklopljeno" ResponseGenerator-->>User: "Izklopljeno" ``` ```mermaid sequenceDiagram participant User participant IntentSystem participant LightControl participant ResponseGenerator User->>IntentSystem: "Nastavi luč v spalnici na 50 odstotkov" IntentSystem->>LightControl: Set brightness in bedroom LightControl-->>ResponseGenerator: Send updated brightness status ResponseGenerator-->>User: "Svetlost v spalnici je nastavljena na 50 odstotkov" ```

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.