Suggested correction to intent response for CO2 sensor

[Sparty76]

Re: intents/tests/en/binary.sensor.HassGetState.yaml

When reviewing the possible phrases, I noticed there are multiple questions and responses that incorrectly use the term "carbon monoxide" to refer to the state of a CO2 sensor.

While I can see a use case for also testing a Carbon Monoxide sensor, CO2 is the chemical formula for Carbon Dioxide, a measure of air quality, not Carbon Monoxide (CO) the more deadly variant from combustion.

Suggest all current references to "monoxide" in this intent configuration be changed to refer to "dioxide" and recommend condider adding separate intents for a CO binary sensor. The issue also exists in other languages. Note: May have implications for the "device_class" as well.

[mitrokun]

There are no binary sensors associated with carbon dioxide. For carbon dioxide, it is important to obtain a numerical value. Everything related to this sensor is located in sensor_HassGetState.yaml

[Sparty76]

Sorry if I wasn't clear in my description. The inconsistency is in the Intents (questions/responses) to control the sensors through Assist not the binary sensors themselves. The questions and device class refer to "carbon monoxide" yet the answers refer to CO2 (which is carbon DI-oxide). The references to CO2 in the responses should refer to "carbon monoxide" to be consistent.

For example in the English translation, I am referring to lines 107-149 of: https://github.com/home-assistant/intents/blob/main/tests/en/binary_sensor_HassGetState.yaml

Below is an example from that yaml file:

• sentences:
  • "are all carbon monoxide sensors on?" intent: name: HassGetState slots: domain: binary_sensor device_class: carbon_monoxide state: "on" response: "No, CO2 is not on"

Thanks for reviewing and considering the suggestion.

[mitrokun]

Thanks for the clarification. This is a typo in the name of the sensor used for the tests. It's not critical at all, but you can fix it.

https://github.com/home-assistant/intents/blob/main/tests/en/_fixtures.yaml#L177