search

home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
453 stars 516 forks source link

[en] Adds set as alias to turn #2352

Open HarvsG opened 3 months ago

HarvsG commented 3 months ago

I had some failures with sentences such as "set all the kitchen lights to off" I do think it's odd phrasing, but after using set for other commands it felt natural turn is an alias of 'set' after all

Summary by CodeRabbit

These updates aim to improve user experience by allowing more intuitive command phrasing and ensuring system accuracy in recognizing varied user inputs.

HarvsG commented 3 months ago 
FAILED tests/test_language_sentences.py::test_fan_HassTurnOff[en] - AssertionError: Recognition failed for 'Set the all the fans to off'
assert None is not None
FAILED tests/test_language_sentences.py::test_light_HassTurnOff[en] - AssertionError: Recognition failed for 'Set the all lights to off'
assert None is not None
FAILED tests/test_language_sentences.py::test_light_HassTurnOn[en] - AssertionError: Recognition failed for 'Set all the first floor lights to on'
assert None is not None
coderabbitai[bot] commented 3 months ago
Walkthrough ## Walkthrough The recent updates enhance the command recognition for fan and light control systems by refining sentence structures and expanding command options. Key modifications include the addition of the word "to" in various command phrases, improving clarity and naturalness. Additionally, new test phrases have been introduced for both fan and light intents, enabling better handling of diverse user inputs, thus ensuring more intuitive interactions with the system. ## Changes | Files | Change Summary | |------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------| | sentences/en/_common.yaml | Expanded the regular expression for `turn` to include "set," enhancing command recognition for device control. | | sentences/en/fan_HassTurnOff.yaml | Modified command phrasing by adding "to" for clarity in turning off fans. | | sentences/en/fan_HassTurnOn.yaml | Similar modifications to command phrasing by including "to" for activating fans. | | sentences/en/light_HassTurnOff.yaml | Adjusted command structures to include "to" for turning off lights, enhancing semantic clarity. | | sentences/en/light_HassTurnOn.yaml | Updated command syntax to include "to" for turning on lights, promoting natural command phrasing. | | tests/en/fan_HassTurnOff.yaml | Added new test phrases for fan deactivation scenarios to improve intent recognition. | | tests/en/fan_HassTurnOn.yaml | Introduced additional test cases for the fan activation intent, enhancing coverage of user commands. | | tests/en/light_HassTurnOff.yaml | Expanded test phrases for light deactivation, ensuring accurate interpretation of user commands. | | tests/en/light_HassTurnOn.yaml | Added new test phrases for light activation to improve natural language understanding and recognition of diverse commands. |
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 82432de5a82192ff4a670f35101a7d59aa894e1e and d64cbd4aaa0cab7b06b866875cf47324fdee21af.
Files selected for processing (9) * sentences/en/_common.yaml (1 hunks) * sentences/en/fan_HassTurnOff.yaml (3 hunks) * sentences/en/fan_HassTurnOn.yaml (2 hunks) * sentences/en/light_HassTurnOff.yaml (4 hunks) * sentences/en/light_HassTurnOn.yaml (4 hunks) * tests/en/fan_HassTurnOff.yaml (3 hunks) * tests/en/fan_HassTurnOn.yaml (2 hunks) * tests/en/light_HassTurnOff.yaml (4 hunks) * tests/en/light_HassTurnOn.yaml (4 hunks)
Additional comments not posted (30)
sentences/en/fan_HassTurnOn.yaml (2)
`8-8`: **Approved: Improved sentence structure for clarity.** The addition of "to" enhances the naturalness and clarity of the command. --- `18-19`: **Approved: Improved sentence structure for clarity.** The addition of "to" enhances the naturalness and clarity of the command.
tests/en/fan_HassTurnOn.yaml (2)
`16-16`: **Approved: Added test case for expanded coverage.** The test case "set the kitchen fans to on" expands the coverage for the `HassTurnOn` intent and aligns with the new sentence structures. --- `31-31`: **Approved: Added test case for expanded coverage.** The test case "set the fans to on" expands the coverage for the `HassTurnOn` intent and aligns with the new sentence structures.
sentences/en/fan_HassTurnOff.yaml (4)
`8-8`: **Approved: Improved sentence structure for clarity.** The addition of "to" enhances the naturalness and clarity of the command. --- `9-9`: **Approved: Improved sentence structure for clarity.** The addition of "to" enhances the naturalness and clarity of the command. --- `18-18`: **Approved: Improved sentence structure for clarity.** The addition of "to" enhances the naturalness and clarity of the command. --- `27-28`: **Approved: Improved sentence structure for clarity.** The addition of "to" enhances the naturalness and clarity of the command.
tests/en/fan_HassTurnOff.yaml (3)
`15-15`: **LGTM!** The added phrase "set the living room fans to off" aligns with the intent and the new alias functionality. --- `29-29`: **LGTM!** The added phrase "Set all the fans to off" aligns with the intent and the new alias functionality. --- `42-42`: **LGTM!** The added phrase "set the fans to off" aligns with the intent and the new alias functionality.
sentences/en/light_HassTurnOn.yaml (5)
`16-16`: **LGTM!** The added phrase "[] [all] [to] on" aligns with the intent and the new alias functionality. --- `17-17`: **LGTM!** The added phrase "[] [all] [in] [to] on" aligns with the intent and the new alias functionality. --- `32-32`: **LGTM!** The added phrase " [to] on" aligns with the intent and the new alias functionality. --- `43-43`: **LGTM!** The added phrase " [to] on" aligns with the intent and the new alias functionality. --- `44-44`: **LGTM!** The added phrase " [to] on" aligns with the intent and the new alias functionality.
sentences/en/light_HassTurnOff.yaml (5)
`16-16`: **LGTM!** The added phrase "[] [all] [to] off" aligns with the intent and the new alias functionality. --- `17-17`: **LGTM!** The added phrase "[] [all] [in] [to] off" aligns with the intent and the new alias functionality. --- `26-26`: **LGTM!** The added phrase " [to] off " aligns with the intent and the new alias functionality. --- `32-32`: **LGTM!** The added phrase " [to] off" aligns with the intent and the new alias functionality. --- `43-43`: **LGTM!** The added phrase " [to] off" aligns with the intent and the new alias functionality.
tests/en/light_HassTurnOff.yaml (4)
`26-26`: **LGTM!** The test phrase "Set the kitchen lights to off" is correctly added and consistent with the intent. --- `49-49`: **LGTM!** The test phrase "Set all the lights to off" is correctly added and consistent with the intent. --- `68-68`: **LGTM!** The test phrase "Set the lights to off" is correctly added and consistent with the intent. --- `87-87`: **LGTM!** The test phrase "Set all the first floor lights to off" is correctly added and consistent with the intent.
tests/en/light_HassTurnOn.yaml (4)
`28-28`: **LGTM!** The test phrase "set the living room lights to on" is correctly added and consistent with the intent. --- `51-51`: **LGTM!** The test phrase "Set all lights to on" is correctly added and consistent with the intent. --- `70-70`: **LGTM!** The test phrase "Set the lights to on" is correctly added and consistent with the intent. --- `89-89`: **LGTM!** The test phrase "Set all the first floor lights to on" is correctly added and consistent with the intent.
sentences/en/_common.yaml (1)
`372-372`: **LGTM!** The addition of "set" to the `turn` key in the expansion rules is consistent with the intent to recognize "set" as an alias for "turn".
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.