home-assistant / intents

Intents to be used with Home Assistant
https://developers.home-assistant.io/docs/voice/overview/
Creative Commons Attribution 4.0 International
453 stars 516 forks source link

[sv] Add timer intents #2357

Closed zyberzero closed 1 month ago

zyberzero commented 3 months ago

Adds sentences, tests and responses for timer intents.

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago
Walkthrough ## Walkthrough The recent updates enhance Swedish language support within a smart home assistant framework by adding new YAML files for various timer-related intents. These changes provide localized responses for actions such as starting, stopping, and modifying timers, along with comprehensive test cases to validate the system's functionality. Enhanced error handling and command structures further improve user interactions, ensuring clarity and responsiveness for Swedish-speaking users. ## Changes | Files | Change Summary | |--------------------------------------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------| | `responses/sv/HassCancelTimer.yaml`, `responses/sv/HassDecreaseTimer.yaml`, `responses/sv/HassIncreaseTimer.yaml`, `responses/sv/HassPauseTimer.yaml`, `responses/sv/HassStartTimer.yaml`, `responses/sv/HassUnpauseTimer.yaml` | New YAML configurations added, defining default response messages for various timer intents, enhancing Swedish language support. | | `sentences/sv/homeassistant_HassCancelTimer.yaml`, `sentences/sv/homeassistant_HassDecreaseTimer.yaml`, `sentences/sv/homeassistant_HassIncreaseTimer.yaml`, `sentences/sv/homeassistant_HassPauseTimer.yaml`, `sentences/sv/homeassistant_HassStartTimer.yaml`, `sentences/sv/homeassistant_HassUnpauseTimer.yaml` | New intent declarations with sentence templates for timer-related actions, improving recognition of user commands. | | `sentences/sv/_common.yaml` | Added error messages and command structures for timer management, enhancing user feedback for timer operations. | | `tests/sv/homeassistant_HassCancelTimer.yaml`, `tests/sv/homeassistant_HassDecreaseTimer.yaml`, `tests/sv/homeassistant_HassIncreaseTimer.yaml`, `tests/sv/homeassistant_HassPauseTimer.yaml`, `tests/sv/homeassistant_HassStartTimer.yaml`, `tests/sv/homeassistant_HassUnpauseTimer.yaml` | Introduced test cases for each timer intent to validate functionality and responses in a Swedish language context. | | `tests/sv/homeassistant_HassTimerStatus.yaml` | Added test cases for the `HassTimerStatus` intent to verify its operational integrity. | | `tests/sv/_fixtures.yaml` | New section added to define timer objects for testing, enhancing the representation of timer attributes in scenarios. |

[!TIP]

New features Walkthrough comment now includes: - Possibly related PRs: A list of potentially related PRs to help you recall past context. - Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file. Notes: - Please share any feedback in the [discussion post](https://discordapp.com/channels/1134356397673414807/1282535539299323995) on our Discord. - Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between fc0e979372011abfef5619e79afa281012fcbc12 and 1ec4eb0fffb5e80af4b2a6250ced02580db71d06.
Files selected for processing (1) * tests/sv/_fixtures.yaml (1 hunks)
Additional comments not posted (1)
tests/sv/_fixtures.yaml (1)
`108-144`: **LGTM!** The addition of the `timers` section in the test fixtures YAML file is well-structured and comprehensive. It allows for the representation of multiple timers, each with its own unique settings and time-related attributes. Some key observations: - The timer objects are defined with appropriate attributes such as `is_active`, `start_hours`, `total_seconds_left`, `rounded_hours_left`, `rounded_minutes_left`, and `rounded_seconds_left`. - The `name` and `area` attributes are optional, providing flexibility in defining timers for different contexts. - The time-related attributes offer a detailed breakdown of the remaining time in various units, which can be useful for testing different scenarios. Overall, this change enhances the test fixtures and enables more comprehensive testing of timer-related functionalities in the Swedish language support. The code changes are approved.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` or `@coderabbitai title` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
home-assistant[bot] commented 3 months ago

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.