home-assistant / my.home-assistant.io

The portal to your home.
https://my.home-assistant.io/
32 stars 19 forks source link

New Blueprint Import links not being created #473

Open dinki opened 1 month ago

dinki commented 1 month ago

I am trying to create a link to this blueprint:

https://raw.githubusercontent.com/dinki/View-Assist/main/View%20Assist%20custom%20sentences/Ask%20AI/blueprint-askai.yaml

Typically the form will complain about the '%20' so I change these to spaces and it works fine. This is not happening. In troubleshooting, I tried formatting using a known working blueprint link created using my.home-assistant.io weeks ago and adjusted it by adding the new path and keeping with the same formatting as the working link. That did not work either.

I then tried to use the known working blueprint import and it appears to not be working now and gives an error when clicking the link:

image

It seems all of the links I've created using the form (https://my.home-assistant.io/create-link/) no longer work though no changes have been made to the repo structure or filenames that would explain this. Here is an example of a previously working link that now gives the error:

Open your Home Assistant instance and show the blueprint import dialog with a specific blueprint pre-filled.

Any help with this is most appreciated. Thanks.

SirGoodenough commented 1 month ago

I have tested this as well with my ow github blueprint links. Both the YAML creation and the Markdown creation from the link tool seem broken. URL works OK. Discord Thread: https://discord.com/channels/330944238910963714/786973377209696266/1265290854042701875 image

So here is not working and lower one created previously working... image

When I paste that into here with code formatting it turns into:

[![Open your Home Assistant instance and show the blueprint import dialog with a specific blueprint pre-filled.]([https://my.home-assistant.io/badges/blueprint_import.svg)](https://my.home-assistant.io/redirect/blueprint_import/?blueprint_url=https%3A%2F%2Fgithub.com%2FSirGoodenough%2FHA_Blueprints%2Fblob%2Fmaster%2FScripts%2Ftts_All_Message_Script_Blueprint.yaml)](https://my.home-assistant.io/badges/blueprint_import.svg)%5D(https://my.home-assistant.io/redirect/blueprint_import/?blueprint_url=https%3A%2F%2Fgithub.com%2FSirGoodenough%2FHA_Blueprints%2Fblob%2Fmaster%2FScripts%2Ftts_All_Message_Script_Blueprint.yaml))

[![Open your Home Assistant instance and show the blueprint import dialog with a specific blueprint pre-filled.](https://my.home-assistant.io/badges/blueprint_import.svg)](https://my.home-assistant.io/redirect/blueprint_import/?blueprint_url=https%3A%2F%2Fgithub.com%2FSirGoodenough%2FHA_Blueprints%2Fblob%2Fmaster%2FScripts%2Ftts_All_Message_Script_Blueprint.yaml)

So something is happening there appears to be an extra square brace in there making it dizzy.

dinki commented 1 month ago

As a follow up to @SirGoodenough observations, here is an example of a link I have that was previously working but now no longer works:

[![Open your Home Assistant instance and show the blueprint import dialog with a specific blueprint pre-filled.](https://my.home-assistant.io/badges/blueprint_import.svg)](https://my.home-assistant.io/redirect/blueprint_import/?blueprint_url=https%3A%2F%2Fraw.githubusercontent.com%2Fdinki%2FView-Assist%2Fmain%2FView+Assist+custom+sentences%2FList+Management%2Fblueprint-listmanagement.yaml)

The formatting is the same as his working example but it is now failing as are all of my blueprint links. It may be related to the spaces in the path as I think that may be the only obvious difference.

dinki commented 1 month ago

Here is a list of previously working blueprints that are now giving errors:

https://my.home-assistant.io/redirect/blueprint_import/?blueprint_url=https%3A%2F%2Fraw.githubusercontent.com%2Fdinki%2FView-Assist%2Fmain%2FView+Assist+control+automations%2Fblueprint-devicecontrol.yaml
https://my.home-assistant.io/redirect/blueprint_import/?blueprint_url=https%3A%2F%2Fraw.githubusercontent.com%2Fdinki%2FView-Assist%2Fmain%2FView+Assist+custom+sentences%2FBroadcast%2Fblueprint-broadcast.yaml
https://my.home-assistant.io/redirect/blueprint_import/?blueprint_url=https%3A%2F%2Fraw.githubusercontent.com%2Fdinki%2FView-Assist%2Fmain%2FView+Assist+custom+sentences%2FHows+the+weather%2Fblueprint-howstheweather.yaml
https://my.home-assistant.io/redirect/blueprint_import/?blueprint_url=https%3A%2F%2Fraw.githubusercontent.com%2Fdinki%2FView-Assist%2Fmain%2FView+Assist+custom+sentences%2FList+Management%2Fblueprint-listmanagement.yaml
https://my.home-assistant.io/redirect/blueprint_import/?blueprint_url=https%3A%2F%2Fraw.githubusercontent.com%2Fdinki%2FView-Assist%2Fmain%2FView+Assist+custom+sentences%2FShow+Webpage%2Fblueprint-showwebpage.yaml
https://my.home-assistant.io/redirect/blueprint_import/?blueprint_url=https%3A%2F%2Fraw.githubusercontent.com%2Fdinki%2FView-Assist%2Fmain%2FView+Assist+custom+sentences%2FSpell+a+Word%2Fblueprint-spellaword.yaml
https://my.home-assistant.io/redirect/blueprint_import/?blueprint_url=https%3A%2F%2Fraw.githubusercontent.com%2Fdinki%2FView-Assist%2Fmain%2FView+Assist+custom+sentences%2FTell+Me+a+Joke%2Fblueprint-tellmeajoke.yaml
https://my.home-assistant.io/redirect/blueprint_import/?blueprint_url=https%3A%2F%2Fraw.githubusercontent.com%2Fdinki%2FView-Assist%2Fmain%2FView+Assist+custom+sentences%2FThank+You%2Fblueprint-thankyou.yaml

My project relies heavily on blueprint imports as a means to add functionality. Any advice on how to proceed is most appreciated.

frenck commented 1 month ago

Is this bound to a specific browser? And anything in the browser console?

frenck commented 1 month ago

Caused by https://github.com/braintree/sanitize-url/pull/77 Related issue: https://github.com/braintree/sanitize-url/issues/78

dinki commented 1 month ago

Is this bound to a specific browser? And anything in the browser console?

I checked console in Chrome and don't see any errors.

Looks like you beat me to the response. Thanks for your quick response on this.

dinki commented 1 month ago

Working again for old links and can create new links. Thanks for reverting.