search

home-assistant / supervised-installer

Installer for a generic Linux system
Apache License 2.0
1.7k stars 583 forks source link

Update postinst - Add OS-agent and AppArmor into grub #331

Closed hellresistor closed 9 months ago

hellresistor commented 11 months ago

Add OS-Agent version detection automaticaly for last version. Add OS-Agent installation Add "apparmor=1 security=apparmor" into '/boot/firmware/cmdline.txt' or '/etc/default/grub' files

home-assistant[bot] commented 11 months ago

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

ikifar2012 commented 11 months ago

I'm not sure if we want the supervised package to install things for the user, not sure what the others think but the ADR states " The user first needs to install Debian and make sure all the required components are installed and are the correct version. They then need to run the installer script." Clearly stating the user is responsible for dependencies

hellresistor commented 11 months ago

without lines about apparmor will get unhealthy system :| (at least on my actually installation). It was a dedicate HA+Debian12aarch64

ikifar2012 commented 11 months ago

After looking into this it appears that apparmor is on by default as per the Debian Wiki https://wiki.debian.org/AppArmor/HowToUse. "If you are using Debian 10 "Buster" or newer, AppArmor is enabled by default so you can skip this step."

hellresistor commented 11 months ago

Interesting, this weekend will make new install and check with my eyes ^^' thank you

github-actions[bot] commented 9 months ago

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.