search

home-assistant / supervisor

:house_with_garden: Home Assistant Supervisor
https://home-assistant.io/hassio/
Apache License 2.0
1.73k stars 634 forks source link

Bump pylint from 3.2.7 to 3.3.0 #5306

Closed dependabot[bot] closed 3 days ago

dependabot[bot] commented 5 days ago

Bumps pylint from 3.2.7 to 3.3.0.

Commits
  • 6350dfa Bump pylint to 3.3.0, update changelog
  • 78f3dfa Bump astroid to 3.3.3 (#9939)
  • b28c1f6 Add check for unnecessary-default-type-args (#9938)
  • bd97b93 [doc framework] Assert that the good and bad example exists in the doc (#9936)
  • 7aa4436 Fix duplicate workflow step ids (#9934)
  • 0950916 [pre-commit] Add codespell, and fix some existing typos (#9912)
  • 3b4a7f9 Add details.rst for c-extension-no-member (#9933)
  • 7d60c27 Explicitly save cache in primer jobs
  • 67acc96 Add additional stdlib deprecations (mostly 3.13) (#9853)
  • 0adf671 Remove old-style classes code, remove check for new-style class (#9925)
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
dependabot[bot] commented 3 days ago

A newer version of pylint exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

agners commented 3 days ago

Anyway I'm fine with it if we want to marge it. But I think if we set the number as high as 10 we're already defeating the purpose of this rule. If a developer encounters 10 positional parameters that is well past the complexity threshold where it is easy to remember and understand what those do. They'll have to look up documentation and match up argument to doc to see what's going on whereas if it was named parameters they might be able to just read and get it.

Isn't that an argument for the rule? I mean, you support the essential idea of trying to avoid too many arguments. Just because between 5 and 10 is already bad, does not mean we cannot have a rule warning when we are above 10. I just picked 10 since there are already functions with 9 in the codebase, but none have 10 or more today. Sure, this won't address the ones between 5 and 10, but this hopefully will encourage that no function will go beyond 10 :sweat_smile: In the end, it helps support what pylint intended: Avoid too many parameters. Granted, we are at a higher level (pylint's default is a rather conservative 5), but IMHO, it is better to keep a warning if it potentially helps? :man_shrugging:

I'll merge as is, we can still drop in case we don't like the warning.