home-climate-control / dz

Home Climate Control Core: *the* Open Source multi-zone temperature and climate control system.
http://homeclimatecontrol.com/
GNU General Public License v3.0
59 stars 7 forks source link

Remove behavior from ZoneSettings #326

Closed climategadgets closed 2 weeks ago

climategadgets commented 2 weeks ago

Existing Behavior

Zone settings exist in three incarnations:

  1. configuration time - all values are allowed, immutable, stateless, no behavior
  2. calendar event configuration time - hold is missing, other values are allowed, immutable, stateless, no behavior
  3. runtime - all values are allowed, custom serialization rules, still stateless, very complex behavior, too smart for its own good

Desired Behavior

Whereas it is not possible to remove the first and second use cases, the third must be split into a record that can be exposed to external systems and successfully deserialized there.

Related Issues

327

climategadgets commented 2 weeks ago

Done as of rev. 95fc38f4ce8d23e3b1130619e1f9e8898fc99cc1