search

homebase-id / homebase-id-app

Other
2 stars 0 forks source link

Feat share composer #229

Closed 2002Bishwajeet closed 1 day ago

stef-coenen commented 3 days ago

Perhaps keep your PR's focused on a single thing? (I know we're all guilty of breaking that rule, but at least reverting should be it's own thing)

And if you do combine features, only put multiple features into the same area together

2002Bishwajeet commented 3 days ago

Perhaps keep your PR's focused on a single thing? (I know we're all guilty of breaking that rule, but at least reverting should be it's own thing)

And if you do combine features, only put multiple features into the same area together

It's a single feature thing (focusing on all the aspects around Share) 🫣

stef-coenen commented 3 days ago

Perhaps keep your PR's focused on a single thing? (I know we're all guilty of breaking that rule, but at least reverting should be it's own thing) And if you do combine features, only put multiple features into the same area together

It's a single feature thing (focusing on all the aspects around Share) 🫣

And yet there's this one 😉: https://github.com/homebase-id/homebase-id-app/pull/229/commits/6fe4cb79423a3001c0d42735b8ace9660763dd34

2002Bishwajeet commented 3 days ago

Perhaps keep your PR's focused on a single thing? (I know we're all guilty of breaking that rule, but at least reverting should be it's own thing) And if you do combine features, only put multiple features into the same area together

It's a single feature thing (focusing on all the aspects around Share) 🫣

And yet there's this one 😉: 6fe4cb7

Mini cleanups doesn't count 😛