homebaseio / homebase-react

The React state management library for write-heavy applications
https://homebase.io/docs/homebase-react
MIT License
202 stars 10 forks source link

fix(datom): attr access #29

Closed becomingbabyman closed 4 years ago

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 0.3.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

rubinovitz commented 4 years ago

@smothers is there a test we can add for this? seems important

becomingbabyman commented 4 years ago

@rubinovitz good question. I'd rather make it a unit test than an integration test to keep it speedy, but I don't think our current unit test suite would catch this. I'm going to think on it. I think the best course of action will be to build out our JS test suite to complement our CLJS suite. The JS tests are a bit slower, but they're closer to integration tests so they have more signal to the final product.