homebridge-eufy-security / plugin

Homebridge plugin to control certain Eufy Security devices
Apache License 2.0
157 stars 24 forks source link

[Bug]: Small, low priority, warning text change - "Couldt" to "Could" in SnapshotManager.ts #265

Closed NeilLamka closed 10 months ago

NeilLamka commented 1 year ago

What happened?

Simple thing, in SnapshotManager.ts, line 326 you have a warning message that should be corrected.

The current message says this.log.warn(this.device.getName(), 'Couldt not get cloud snapshot: ' + err);

and should read this.log.warn(this.device.getName(), 'Could not get cloud snapshot: ' + err);

by changing "Coudt" to "Could"

Device Type

other (UnSupported)

Plugin Version

v2.0.x (Supported)

HomeBridge Version

v1.4.x (Supported)

NodeJS Version

v12 (Supported)

Operating System

Other (UnSupported)

Relevant log output

[EufySecurity-2.1.4] WARN:  Deck Couldt not get cloud snapshot: Error: unable to verify the first certificate
[1/4/2023, 8:28:02 AM] [EufySecurity-2.1.4] WARN:  Deck snapshot handler is initialized without cloud snapshot. Maybe no snapshot will displayed the first times.
[1/4/2023, 8:28:02 AM] [EufySecurity-2.1.4] WARN:  Front Door Couldt not get cloud snapshot: Error: unable to verify the first certificate
[1/4/2023, 8:28:02 AM] [EufySecurity-2.1.4] WARN:  Front Door snapshot handler is initialized without cloud snapshot. Maybe no snapshot will displayed the first times.
[1/4/2023, 8:28:02 AM] [EufySecurity-2.1.4] WARN:  Driveway Couldt not get cloud snapshot: Error: unable to verify the first certificate
[1/4/2023, 8:28:02 AM] [EufySecurity-2.1.4] WARN:  Driveway snapshot handler is initialized without cloud snapshot. Maybe no snapshot will displayed the first times.

config

{
            "platform": "EufySecurity",
            "username": "*************",
            "password": "************",
            "ignoreStations": [],
            "ignoreDevices": [],
            "country": "US",
            "cameras": [
                {
                    "serialNumber": "T8114P0220130947",
                    "enableCamera": true,
                    "enableButton": true,
                    "motionButton": true,
                    "rtsp": true,
                    "unbridge": true,
                    "forcerefreshsnap": false,
                    "useCachedLocalLivestream": false,
                    "videoConfig": {
                        "audio": true
                    }
                },
                {
                    "serialNumber": "T8114P0220130333",
                    "enableCamera": true,
                    "enableButton": true,
                    "motionButton": true,
                    "rtsp": false,
                    "unbridge": true,
                    "forcerefreshsnap": false,
                    "useCachedLocalLivestream": false,
                    "videoConfig": {
                        "audio": true
                    }
                },
                {
                    "serialNumber": "T8114P0220300F75",
                    "enableCamera": true,
                    "enableButton": true,
                    "motionButton": true,
                    "rtsp": true,
                    "unbridge": true,
                    "forcerefreshsnap": false,
                    "useCachedLocalLivestream": false,
                    "videoConfig": {
                        "audio": true
                    }
                }
            ],
            "cleanCache": true,
            "deviceName": "Beach Cameras"
        }
github-actions[bot] commented 1 year ago

Did you check this Common Issues pages ?

github-actions[bot] commented 1 year ago

Did you check this Road Map pages ?

NeilLamka commented 1 year ago

I don’t see anything on the road map that seems to be related to my small defect. Is there one that I’ve missed?

Thanks Neil

Neil Lamka

Mobile: 206-931-0229

@.**@.>

Sam Boni Clothing Companyhttp://www.sam-boni.com/


From: github-actions[bot] @.> Sent: Monday, January 23, 2023 12:50:49 AM To: homebridge-eufy-security/plugin @.> Cc: Neil Lamka @.>; Author @.> Subject: Re: [homebridge-eufy-security/plugin] [Bug]: Small, low priority, warning text change - "Couldt" to "Could" in SnapshotManager.ts (Issue #265)

Did you check this Road Maphttps://github.com/homebridge-eufy-security/plugin/projects/1 pages ?

— Reply to this email directly, view it on GitHubhttps://github.com/homebridge-eufy-security/plugin/issues/265#issuecomment-1400147125, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAYUEQHVX6GWHPIEBNKCP5DWTZPATANCNFSM6AAAAAATQ7572Y. You are receiving this because you authored the thread.Message ID: @.***>

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

NeilLamka commented 10 months ago

Marking this as an enhancement vs as a defect seems strange to me. That said, it does appear from the status and the issue being “stale” the team is not interested in the details.

lenoxys commented 10 months ago

I am

lenoxys commented 10 months ago

in fact it was fixed in 2.2 release.