homebridge-plugins / homebridge-august

The Homebridge August plugin allows you to access your August/Yale Locks from HomeKit with Homebridge.
ISC License
36 stars 9 forks source link

Bug: #100

Closed TommyGKiwi closed 7 months ago

TommyGKiwi commented 8 months ago

Describe The Bug

API default poll rate 1800s is incosistent with text 5m/360s

To Reproduce

change the default refresh rate

Expected behavior

text default/value should match values

Relevant log output

warning message is sent if you change the default refresh rate ....
code shows the inconsistency:
platform.ts
if (!this.config.options.refreshRate) {
      // default 1800 seconds (30 minutes)
      this.config.options!.refreshRate! = 1800;
      this.debugWarnLog('Using Default Refresh Rate (5 minutes).');
    } else if (this.config.options.refreshRate < 1800) {
      this.config.options.refreshRate = 1800;
      this.warnLog('Refresh Rate cannot be set to lower the 5 mins, as Lock detail (battery level, etc) are unlikely to change within that period');
    }

Config for homebridge-august

"lockId": "BBA8ACA18E424FEDB6AB40AE84A0FAE1",
                        "configLockName": "Front Door",
                        "lock": {
                            "hide_contactsensor": true
                        },
                        "refreshRate": 360

Screenshots

IMG_2648

Device & Model

rpi

Node.js Version

v20.11.1

NPM Version

???

Homebridge Version

v1.7.0

Homebridge August Plugin Version

v2.0.0

Homebridge Config UI X Plugin Version

No response

Operating System

Debian GNU/Linux Bookworm (12)

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 7 months ago

This issue has been closed as no further activity has occurred.

donavanbecker commented 5 months ago

Please try v2.1.0, if you still have an issue please open a new issue.