Closed evantobin closed 1 year ago
@evantobin, I have re-based this to the beta-1.0.6 branch. Can you resolve the conflicts? or close this PR and create a new one based on the beta-1.0.6 branch?
I'll create a new one on the beta branch. Github by default only forked the latest branch.
Thanks!
Parse validateCode as an integer. We could make the UI take in an integer, but then the user is presented with a number selector which isn't ideal. Easiest to keep it as a string in the UI and just parse it as an int on the backend.
:recycle: Current situation
The Homebridge UI puts the verification code in the config as a string which causes an authentication error on august's servers. Changing it to an int works, but then you have to manually update the config.
:bulb: Proposed solution
Add parseInt before the code is sent to the server. This way both integer and string verification codes will work right with august's servers.
:gear: Release Notes
Plugin now works correctly with string-based verification code configs.
Testing
N/A