homebridge-plugins / homebridge-august

The Homebridge August plugin allows you to access your August/Yale Locks from HomeKit with Homebridge.
ISC License
36 stars 9 forks source link

Fix 'Locking...' and 'Unlocking...' issue #66

Closed dacarson closed 1 year ago

dacarson commented 1 year ago

When a lock is unlocked or locked manually, the event is correctly sent to the plugin, and the current state is updated. The lock target state also needs to be updated to match the current state.

:recycle: Current situation

As the Target state is not updated, it is stale, and reflects the last state of the lock. Which is often the opposite of the new Current state. So in the HomeKit UIs it will show that the lock is currently transitioning from the Current state to the Target state, and the UI will be stuck there until the user either uses HomeKit to change the lock state, or manually restores the lock to the previous state.

:bulb: Proposed solution

When the event arrives that the user has manually changed the lock state, also update the Target lock state to match.

:gear: Release Notes

Fixes issue https://github.com/donavanbecker/homebridge-august/issues/22 where manual lock changes result in Home app showing the lock stuck in transition mode.

Testing

Manually tested on my Homebridge setup with two August Locks (AUG-SL04-M01-G04) that do not have DoorSense setup. Manual testing included:

Reviewer Nudging

Focus on when a lock state change happens externally to HomeKit.

jspiro commented 1 year ago

Ready to help test as soon as this is available in the 1.2 beta release. I use DoorSense.