search

homebridge-plugins / homebridge-govee

Homebridge plugin to integrate Govee devices into HomeKit.
MIT License
489 stars 49 forks source link

Is the updatePlatformAccessories call really correct? #303

Closed Apollon77 closed 2 years ago

Apollon77 commented 2 years ago

You have a updatePlatformAccessories call here https://github.com/bwp91/homebridge-govee/blob/5ba6337c05a39f5951b94dd4105b1a7a00da437d/lib/platform.js#L837 ... but the current specs just support https://github.com/homebridge/homebridge/blob/master/src/api.ts#L343 ... there is a parameter mismatch or?!

bwp91 commented 2 years ago

Hi @Apollon77 This is something i have not looked into for a long time since no issues have ever been reported. But looks like you are right with the parameters. Looks like i have a lot of plugins to update! Thanks for pointing this out, I will let you know when i have fixed 👍🏻

Apollon77 commented 2 years ago

I just wondered why updates do not work for my homebridge plug-in wrapper and sunbird over that. I also checked other plugins and they do it the other way .. then have fun updating. At least for one my PR might help ;-))

bwp91 commented 2 years ago

Can you try the beta 6.0.0-beta.1? I have updated the updatePlatformAccessories function to only one argument for homebridge-govee.

If it works for you then I will update the rest of my plugins :)

Apollon77 commented 2 years ago

I did that locally on my system too before ... I will re-check with new version tomorrow

Apollon77 commented 2 years ago

looks good to me from the one test account I could check

bwp91 commented 2 years ago

Closing this as fixed in v6. thanks @Apollon77 for bringing this to my attention. is also fixed in all my other plugins too.