search

homebridge-plugins / homebridge-gsh

Allow Google Assistant to control your Homebridge accessories.
https://assistant.google.com/services/a/uid/000000b558f0d5d1?hl=en
GNU General Public License v3.0
6 stars 2 forks source link

Treat `HeaterCooler` as `AC_UNIT` if it supports `RotationSpeed` #4

Closed noamcohen97 closed 2 weeks ago

noamcohen97 commented 2 weeks ago

:recycle: Current situation

Currently HeaterCooler is exposed as thermostat and it lacks fan speed control

:bulb: Proposed solution

This PR treats it as AC_UNIT if it can satisfy the required traits

:gear: Release Notes

HeaterCooler with the RotationSpeed characteristic will be synced as type AC_UNIT

NorthernMan54 commented 2 weeks ago

Tks, but could you do this against the current beta branch. I needed to do a major refresh of the code base for software currency, and redid the connection code to homebridge.

PS I'm not planning any major changes with the beta in the near future, unless a major issue is identified, and am just letting the beta circulate for a bit, before releasing it to the world

noamcohen97 commented 2 weeks ago

Thanks @NorthernMan54, I rebased it on top of the new beta. The temperature set / mode change is not showing in the Google Home App for some reason, but works just fine with the voice assistant - any idea why is that? Maybe that's a bug in the mobile app (link)?

NorthernMan54 commented 2 weeks ago

I’m going to merge this, so I can do more testing with this.

NorthernMan54 commented 2 weeks ago

Beta 14 contains this

NorthernMan54 commented 2 weeks ago

Looking deeper at the differences between a thermostat device and a AC Unit and wouldn't leaving it as a Thermostat be better ?

Adding fan speed is a great addition.

noamcohen97 commented 2 weeks ago

As a thermostat my voice assistant didn't respond well to commands like "Turn of the AC", but maybe it is related to the OnOff trait.

NorthernMan54 commented 2 weeks ago

Am thinking to stop existing users from having issues with a unit that supports heat and cool, have to leave it as a Thermostat and not an AC. ( As HomeKit will tell you what modes a unit supports, you could tweak it so that if a unit only supports cool, have it be a AC Type ). In HomeKit is yours just cool or is it heat and cool ?

NorthernMan54 commented 2 weeks ago

In the final beta, I left the heater cooler type as a thermostat. We can re-address in the future