search

homebridge-plugins / homebridge-roomba2

Homebridge plugin to connect iRobot Roomba devices with Homebridge/HomeKit.
MIT License
146 stars 17 forks source link

After i7 Update - "unsupported feature: evac" #114

Closed floriangrotz closed 2 years ago

floriangrotz commented 2 years ago

Expected Behavior

No error

Current Behavior

[01/05/2022, 13:41:43] [Bonny] Unsupported phase: evac [01/05/2022, 13:41:43] [Bonny] Unsupported phase: evac [01/05/2022, 13:41:53] [Bonny] Unsupported phase: evac [01/05/2022, 13:41:53] [Bonny] Unsupported phase: evac [01/05/2022, 13:42:03] [Bonny] Unsupported phase: evac [01/05/2022, 13:42:03] [Bonny] Unsupported phase: evac [01/05/2022, 13:42:13] [Bonny] Unsupported phase: evac

Steps to Reproduce (for bugs)

Update to 22.7.2 https://homesupport.irobot.com/s/article/19549

"Improvement to ‘Bin Full’ detection algorithm"

Versions

Roomba i7 - 22.7.2 Homebridge 1.4.1

Configuration

Contact Sensor "Bin full" enabled


### Homebridge Log / Command Output
[01/05/2022, 13:41:43] [Bonny] Unsupported phase: evac
[01/05/2022, 13:41:43] [Bonny] Unsupported phase: evac
[01/05/2022, 13:41:53] [Bonny] Unsupported phase: evac
[01/05/2022, 13:41:53] [Bonny] Unsupported phase: evac
[01/05/2022, 13:42:03] [Bonny] Unsupported phase: evac
[01/05/2022, 13:42:03] [Bonny] Unsupported phase: evac
[01/05/2022, 13:42:13] [Bonny] Unsupported phase: evac
humantree commented 2 years ago

For what it's worth, I have the "Bin full" contact sensor disabled and I'm also seeing this log.

grigarr commented 2 years ago

I see this log as well and my cleaning job will never finish I'm assuming because the phase isn't supported in the upstream openHAB library. It looks like the code here: https://github.com/openhab/openhab-addons/tree/main/bundles/org.openhab.binding.irobot needs to be updated to support an evac phase, and then https://github.com/karlvr/homebridge-roomba2/blob/eee10e656b585f83679a1ab9cb6fce8e5ac28375/src/accessory.ts#L659 needs an update to handle the evac state.

I don't see an issue filed with https://github.com/openhab/openhab-addons yet. Does that need to be opened first?

jlg89 commented 2 years ago

Same error here. This is an i3+, firmware 2.4.7, updated 06 Aug. Doesn't seem to be causing operational issues, just warnings in the log.

8/29/2022, 9:55:50 AMRoomba BridgeRoombaStarting Roomba
8/29/2022, 1:48:15 PMRoomba BridgeRoomba WARNING Unsupported phase: evac
8/29/2022, 1:48:15 PMRoomba BridgeRoomba WARNING Unsupported phase: evac
karlvr commented 2 years ago

Is the "evac" phase when it empties its bin or something like that? It sounds like we should treat it like the clean has ended, so I'll add support for it to be treated as a stop.

karlvr commented 2 years ago

Please try out 1.3.2-beta.2 (or later) and report back whether or not that resolves this issue!

karlvr commented 2 years ago

Please try out 1.4.0 release. Hopefully this resolves the issue. I'm closing this preemptively; please re-open if it doesn't work as expected!

jlg89 commented 1 year ago

FWIW, this seems to have fixed the issue. The "evac" phase is indeed when it empties its bin, which typically happens more than once during a job (depending on the size of the job/house), and the robot usually hangs out on the base to recharge after emptying its bin. So "evac" might be an end-of-job stop, or a mid-job pause. Treating it as a stop is probably good enough, though.