homebridge-plugins / homebridge-roomba2

Homebridge plugin to connect iRobot Roomba devices with Homebridge/HomeKit.
MIT License
143 stars 17 forks source link

Node 18 causes connection failures to Roomba #126

Closed Skyman81 closed 1 year ago

Skyman81 commented 1 year ago

After last update of Homebridge I got this message:

DC41C783-1DB5-4392-88AD-54D0A8FF77E0

Roomba (mode 671) is well connected to wifi and his iRobot account… it’s only NOT working via homekit and HB.

jeanchrijaz commented 1 year ago

same issue with Roomba 980 the device is no longer detected in the home app

NateUT99 commented 1 year ago

Did you upgrade nodejs to v18.x? I was having this exact issue and downgraded to v16.18.1 and it resolved my issues. My guess is this plugin will need to be updated in order to support v18.x (there are a few others where this is causing issues too).

This can be done by running this command from the terminal on your Homebridge host: sudo hb-service update-node 16.18.1

Skyman81 commented 1 year ago

Did you upgrade nodejs to v18.x? I was having this exact issue and downgraded to v16.18.1 and it resolved my issues. My guess is this plugin will need to be updated in order to support v18.x (there are a few others where this is causing issues too).

This can be done by running this command from the terminal on your Homebridge host: sudo hb-service update-node 16.18.1

Thank you IT WORKS!!!! Do you think the pluggin will be updated to the new nodeJS?

thehauntedmattress commented 1 year ago

Downgrading to Node 16.18.1 also fixed this exact same issue for me.

jordanwmcdonald commented 1 year ago

I am having this same issue and downgrading to Node 16.18.1 also fixed this exact same issue for me. Thank you @NateUT99

jeanchrijaz commented 1 year ago

Did you upgrade nodejs to v18.x? I was having this exact issue and downgraded to v16.18.1 and it resolved my issues. My guess is this plugin will need to be updated in order to support v18.x (there are a few others where this is causing issues too).

This can be done by running this command from the terminal on your Homebridge host: sudo hb-service update-node 16.18.1

you only have rommba plugin? because many other plugins require the new update of Homebrige downgrade works but it is an "emergency repair"...

NateUT99 commented 1 year ago

Did you upgrade nodejs to v18.x? I was having this exact issue and downgraded to v16.18.1 and it resolved my issues. My guess is this plugin will need to be updated in order to support v18.x (there are a few others where this is causing issues too). This can be done by running this command from the terminal on your Homebridge host: sudo hb-service update-node 16.18.1

you only have rommba plugin? because many other plugins require the new update of Homebrige downgrade works but it is an "emergency repair"...

No, I have quite a few plugins… only one puts up a warning wanting v18 but it still functions. I agree, getting the plug-in updated is the best course of action; hopefully the author will (or someone will pick it up and continue working on it… all off the roomba plugins seem to be a bit stale at the moment).

jordanwmcdonald commented 1 year ago

@Skyman81 could you please update the title of this issue? A more actionable title will improve the chances of this issue being picked up and, therefore, resolved. May I suggest: "Plugin Stops Working After Update to Node.js 18.x"

NateUT99 commented 1 year ago

Seems like this might have been a temporary solution... the problem has returned on my end. :(

karlvr commented 1 year ago

I've upgraded my setup and I'm trying to ascertain where's it's busted!

karlvr commented 1 year ago

I hope this is resolved with version 1.3.2-beta.1. Please try it out and re-open this issue if there are still Node 18 connection failures.

NateUT99 commented 1 year ago

I hope this is resolved with version 1.3.2-beta.1. Please try it out and re-open this issue if there are still Node 18 connection failures.

I’ll give it a shot when I return home tomorrow!

Poonk81 commented 1 year ago

The beta works fine!! Thank you!

karlvr commented 1 year ago

@Poonk81 thank you very much for the confirmation. If you have time, there's another beta that tackles issues such as waking up Roomba less frequently. It would be great to know that it's still working nicely.

thehauntedmattress commented 1 year ago

The beta fixed this issue for me as well running Node 18.x.

Poonk81 commented 1 year ago

@Poonk81 thank you very much for the confirmation. If you have time, there's another beta that tackles issues such as waking up Roomba less frequently. It would be great to know that it's still working nicely.

I‘m using 1.3.2 beta 2 and it works fine.

NateUT99 commented 1 year ago

Looks like plenty of positive feedback already, but just to add my own... installed 1.3.2-beta4 and NodeJS 18.12.1 and everything appears to be working as expected. Will start to watch and see if issues where Roomba makes the negative tone (and doesn't start) returns (will open new issue if it does).

karlvr commented 1 year ago

@NateUT99 thanks for that. It's always good to hear lots of 👍 before making a release. Especially with the latest beta as I did make a few releases over the weekend.

I think I might have fixed the negative tone and not starting issue in 931ba0d0c2b6fd3566a51af93f728c383fe7621b with any luck, which was in beta 4.

NateUT99 commented 1 year ago

@NateUT99 thanks for that. It's always good to hear lots of 👍 before making a release. Especially with the latest beta as I did make a few releases over the weekend.

I think I might have fixed the negative tone and not starting issue in 931ba0d with any luck, which was in beta 4.

Based on your comments in that commit, I’m optimistic that might just do the trick… will report back after a few days!

jeanchrijaz commented 1 year ago

@karlvr beta3 worked better for me since I installed 1.3.2-beta4 and NodeJS 18.12.1 and I have a lot of disconnection the robot is no longer detected in homebridge and the home app without any error in the logs I had to downgraded NodeJS to v16.18.0 and v1.3.1 for roomba plugin too much trouble with beta4

karlvr commented 1 year ago

@jeanchrijaz thanks for your feedback. That is weird. Could I put upon you to try beta4 again and see perhaps turn on Debug logging on the plugin? It's one of the plugin options (right down the bottom). That way we might learn something that helps us track down what's occurring for you.

jeanchrijaz commented 1 year ago

@jeanchrijaz thanks for your feedback. That is weird. Could I put upon you to try beta4 again and see perhaps turn on Debug logging on the plugin? It's one of the plugin options (right down the bottom). That way we might learn something that helps us track down what's occurring for you.

I did not have the problem immediately but a few days later I have a roomba 980 with a static ip the rebot was restarted but it loses connection with homebridge and home app. I will retest tonight or tomorrow with Debug logging activated.

karlvr commented 1 year ago

@jeanchrijaz I've just released a new beta to tune a few things. beta5. Please give that a try and let us know how it goes.

jeanchrijaz commented 1 year ago

@karlvr ok I will test tonight (I'm not at home)

EDIT beta5 installed for now everything seems to be working fine

karlvr commented 1 year ago

This new beta seems to be working well enough to release and resolve these Node 18 issues for everyone. Please upgrade to v1.4.0.