homebridge-plugins / homebridge-roomba2

Homebridge plugin to connect iRobot Roomba devices with Homebridge/HomeKit.
MIT License
144 stars 17 forks source link

Resolve endless loop that blocks homebridge #16

Closed dvcrn closed 3 years ago

dvcrn commented 3 years ago

this.disableWait doesn't exist anymore so getStatus kept on recursing on itself. This commit removes this.disableWait and makes getStatus a bit morereadable.

Also added a comment to enableAutoRefresh because it was a bit unclear (to me) how it actually handles the auto-refresh

Fixes https://github.com/iRayanKhan/homebridge-roomba2/issues/10

iRayanKhan commented 3 years ago

Should be merged in a few hours. Thank you for this!

Just need to run it when I get home, and it will be on NPM.

iRayanKhan commented 3 years ago

Thank you!

NPM: 1.2.0