search

homebridge-plugins / homebridge-roomba2

Homebridge plugin to connect iRobot Roomba devices with Homebridge/HomeKit.
MIT License
146 stars 17 forks source link

Correct double calling of callback when using expired status #49

Closed karlvr closed 3 years ago

karlvr commented 3 years ago

Fixes #39

Simply missing a return of the cached status, which meant it would go on to call the callback again saying it had failed and triggering the error message:

This plugin threw an error from the characteristic 'Contact Sensor State': Unhandled error thrown inside read handler for characteristic: This callback function has already been called by someone else; it can only be called one time.. See https://git.io/JtMGR for more info.
donavanbecker commented 3 years ago

@karlvr Would you like to take ownership of this repo?

karlvr commented 3 years ago

@donavanbecker not dearly, but if there's no one else looking after it I can try to whip it into shape. I do have my Roomba connected to my Homebridge, so I do have a vested interest.

donavanbecker commented 3 years ago

Do you have an npm login?

karlvr commented 3 years ago

@donavanbecker cool, I'm karlvr

donavanbecker commented 3 years ago

Okay i am going to merge your PRs into the repo, then you have to delete your fork of homebridge-roomba and I can then transfer the repo too you.

karlvr commented 3 years ago

@donavanbecker okay, I've done so.

donavanbecker commented 3 years ago

once you accept the request. the repo is yours and you should be able to publish updates.

karlvr commented 3 years ago

@donavanbecker sorry, I missed the email window. Could you please send again?

donavanbecker commented 3 years ago

@karlvr transfer request sent again.

And if you could transfer back to this plugin group or myself if you choose not to manage this anymore... that would be great.