search

homebridge-plugins / homebridge-roomba2

Homebridge plugin to connect iRobot Roomba devices with Homebridge/HomeKit.
MIT License
146 stars 17 forks source link

Updating docs for configuring plugin #61

Closed SpencerKaiser closed 3 years ago

SpencerKaiser commented 3 years ago

Modified the docs with slightly clearer instructions, replaced 1, 2, 3 numbering to make future updates easier (you don't need to renumber when adding a step in the middle)

Also added a comment about the need for a static IP address

Let me know if you have any feedback

karlvr commented 3 years ago

@SpencerKaiser thank you very much for this PR. That's an interesting point about your Roomba and its IP address. I don't think my Roomba has a static IP... it's just managed to retain its IP address lease I guess. Have you had a problem with your Roomba's IP address changing?

I am making some changes to the README layout, but I will endeavour to incorporate your changes once we've resolved whether we want to scare people with static IPs!

Perhaps if it doesn't seem like a widespread issue we could add a Troubleshooting section with a "check if your Roomba's IP address has changed" part.

SpencerKaiser commented 3 years ago

Have you had a problem with your Roomba's IP address changing? No but I just figured this would be an issue... if not, you have some magic on your end for how you communicate with the Roomba after a router restart 🤔 I also saw #36 which sounded like the same issue.

Let me take another pass at formatting based on your feedback and you can let me know what you think 😉

SpencerKaiser commented 3 years ago

Ah, never mind... looks like you already made my other changes in another PR ☹️

karlvr commented 3 years ago

@SpencerKaiser I have made some large changes in the last couple of days, but I haven't incorporated anything about static IP addresses, or anything about IP addresses at all I think... I do think that a troubleshooting section would be useful, and an instruction to check the IP would be valuable if you feel like adapting what you've written to go there?